ArduPilot mission_raw fixes #2222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like I broke the tests. |
It turns out we were using our instead of the system's autopilot type (e.g. PX4 or ArduPilot) in the transfer from the mission client and param client. This should fix the timeout happening for ArduPilot (as ArduPilot responds to MISSION_COUNT with MISSION_REQUEST instead of MISSION_REQUEST_INT). Signed-off-by: Julian Oes <[email protected]>
julianoes
force-pushed
the
pr-fix-ardupilot-mission
branch
from
3cfdead to
df9b2d5
Compare
JonasVautherin
previously approved these changes
Feb 19, 2024
We need to enter the home item before adding the sequence numbering. Signed-off-by: Julian Oes <[email protected]>
julianoes
force-pushed
the
pr-fix-ardupilot-mission
branch
from
df9b2d5 to
dc919d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an
InvalidSequencewhen using QGC plan import, and aTimeoutwhen trying to upload, both for ArduPilot.