Use VariableNode on "settings" configuration #370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pan93412
force-pushed
the
use-variable-node-on-settings
branch
from
e35b4d5 to
492623f
Compare
|
note: in future we'll switch to fully defined settings structure |
pan93412
force-pushed
the
use-variable-node-on-settings
branch
2 times, most recently
from
7e6113e to
4577461
Compare
pan93412
changed the title
"arrayNode" does not support arbitrary configuration keys. Therefore, I switch to variableNode with dynamic check. Fixed meilisearch#369
pan93412
force-pushed
the
use-variable-node-on-settings
branch
from
4577461 to
7aa5aac
Compare
pan93412
changed the title
|
@norkunas Seems like it generates a ConfigBuilder that allow passing arbitrary array.
Sadly, I cannot make it work locally. It might not the fault of my code in this PR; maybe I need some additional code to make it registered?
|
|
I'm not sure how to test that in a bundle |
https://symfony.com/doc/current/configuration.html#using-php-configbuilders; however, I afraid the types are generated only on the consumer. I don't really find a way to test it just in this bundle. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #370 +/- ##
============================================
+ Coverage 88.69% 88.73% +0.03%
Complexity 1 1
============================================
Files 20 20
Lines 911 914 +3
============================================
+ Hits 808 811 +3
Misses 103 103 ☔ View full report in Codecov by Sentry. |
norkunas
reviewed
Dec 3, 2024
pan93412
force-pushed
the
use-variable-node-on-settings
branch
from
5eda9ab to
43dc7b3
Compare
pan93412
force-pushed
the
use-variable-node-on-settings
branch
from
43dc7b3 to
9fafbff
Compare
norkunas
reviewed
Dec 3, 2024
pan93412
force-pushed
the
use-variable-node-on-settings
branch
from
59c728f to
acf34e4
Compare
norkunas
approved these changes
Dec 3, 2024
|
bors merge |
|
Thank you @pan93412 |
3 tasks
meili-bors bot
added a commit
that referenced
this pull request
Dec 3, 2024
371: Fix: Container extension "meili_search" is not registered. r=norkunas a=pan93412 # Pull Request ## Related issue #370 (comment) ## What does this PR do? "meili_search" does not match the bundle name, "meilisearch," which causes some strange bugs, such as this issue. I have completed a basic smoke test of PHP and YAML. I can confirm that the PHP configuration is now working with the Meilisearch bundle, while the old YAML configuration should function as it did before. ```bash $ php bin/console meilisearch:import --update-settings Importing for index App\Entity\Question Indexed a batch of 70 / 70 App\Entity\Question entities into dev_questions index (70 indexed since start) Setting "filterableAttributes" updated of "dev_questions". Setting "sortableAttributes" updated of "dev_questions". Done! ``` ## PR checklist Please check if your PR fulfills the following requirements: - [x] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)? - [x] Have you read the contributing guidelines? - [x] Have you made sure that the title is accurate and descriptive of the changes? Thank you so much for contributing to Meilisearch! Co-authored-by: Yi-Jyun Pan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Related issue
Fixes #369
What does this PR do?
"arrayNode" does not support arbitrary configuration keys. Therefore, I switch to variableNode with dynamic check.
PR checklist
Please check if your PR fulfills the following requirements:
Thank you so much for contributing to Meilisearch!