-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Container extension "meili_search" is not registered. #371
Fix: Container extension "meili_search" is not registered. #371
Conversation
"meili_search" does not match the bundle name, "meilisearch". It makes some weird bugs, like this issue.
0f3d767
to
5e19616
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #371 +/- ##
=========================================
Coverage 88.73% 88.73%
Complexity 1 1
=========================================
Files 20 20
Lines 914 914
=========================================
Hits 811 811
Misses 103 103 ☔ View full report in Codecov by Sentry. |
But isn't this a BC break for others? Edit: hmm, strange, in my app I am using |
https://github.com/search?q=path%3Aconfig%2Fpackages%2Fmeilisearch.php&type=code Besides, there was basically nobody like me who successfully applied |
bors merge |
Thank you @pan93412 |
Pull Request
Related issue
#370 (comment)
What does this PR do?
"meili_search" does not match the bundle name, "meilisearch," which causes some strange bugs, such as this issue.
I have completed a basic smoke test of PHP and YAML. I can confirm that the PHP configuration is now working with the Meilisearch bundle, while the old YAML configuration should function as it did before.
PR checklist
Please check if your PR fulfills the following requirements:
Thank you so much for contributing to Meilisearch!