Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

⚠️ Change the way IPAM is deployed with CAPM3 and Test changes made in IPAM and CAPM3 together #1459

Merged
merged 1 commit into from
Feb 25, 2025
Merged

⚠️ Change the way IPAM is deployed with CAPM3 and Test changes made in IPAM and CAPM3 together #1459

merged 1 commit into from
Feb 25, 2025

Conversation

peppi-lotta
Copy link
Member

@peppi-lotta peppi-lotta commented Sep 23, 2024 •
edited
Loading

When making IPAm into a provider for CAPI, I needed to change the namespace where IPAM is living and how IPAM is deployed. This PR is made to match those changes in IPAM. There are also changes to CAPM3 These are the related PRs:

These new changes are dependent from each other so the test are not passing in the PRs. This PR changes the way IPAM is deployed with CAMP3 and tests the 2 dependent PR branches together.

@metal3-io-bot metal3-io-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 23, 2024
@peppi-lotta
Copy link
Member Author

/test metal3-dev-env-integration-test-ubuntu-main

1 similar comment
@mquhuy
Copy link
Member

mquhuy commented Sep 23, 2024

/test metal3-dev-env-integration-test-ubuntu-main

@peppi-lotta peppi-lotta force-pushed the peppi-lotta/test-CAPM3-and-IPAM-changes-together branch from 54c69b2 to f522417 Compare September 30, 2024 10:56
@metal3-io-bot metal3-io-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 30, 2024
@peppi-lotta
Copy link
Member Author

/test metal3-dev-env-integration-test-ubuntu-main

@peppi-lotta peppi-lotta force-pushed the peppi-lotta/test-CAPM3-and-IPAM-changes-together branch from f522417 to 809df47 Compare September 30, 2024 11:48
@peppi-lotta
Copy link
Member Author

/test metal3-dev-env-integration-test-ubuntu-main

@peppi-lotta peppi-lotta force-pushed the peppi-lotta/test-CAPM3-and-IPAM-changes-together branch from 809df47 to 9ef6cc2 Compare September 30, 2024 12:15
@peppi-lotta
Copy link
Member Author

/test metal3-dev-env-integration-test-ubuntu-main

@peppi-lotta peppi-lotta force-pushed the peppi-lotta/test-CAPM3-and-IPAM-changes-together branch from 9ef6cc2 to b269826 Compare October 1, 2024 09:40
@metal3-io-bot metal3-io-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 1, 2024
@peppi-lotta
Copy link
Member Author

/test metal3-dev-env-integration-test-ubuntu-main

@peppi-lotta peppi-lotta force-pushed the peppi-lotta/test-CAPM3-and-IPAM-changes-together branch 2 times, most recently from 37b23a2 to 4742bea Compare October 2, 2024 06:25
@peppi-lotta
Copy link
Member Author

/test metal3-dev-env-integration-test-ubuntu-main

@peppi-lotta peppi-lotta force-pushed the peppi-lotta/test-CAPM3-and-IPAM-changes-together branch from 4742bea to 85efbfa Compare October 2, 2024 07:59
@peppi-lotta
Copy link
Member Author

/test metal3-dev-env-integration-test-ubuntu-main

1 similar comment
@peppi-lotta
Copy link
Member Author

/test metal3-dev-env-integration-test-ubuntu-main

@peppi-lotta peppi-lotta force-pushed the peppi-lotta/test-CAPM3-and-IPAM-changes-together branch from 85efbfa to e5e954c Compare October 9, 2024 07:26
@peppi-lotta
Copy link
Member Author

/test metal3-dev-env-integration-test-ubuntu-main

@peppi-lotta peppi-lotta force-pushed the peppi-lotta/test-CAPM3-and-IPAM-changes-together branch from e5e954c to 85a3585 Compare October 9, 2024 08:49
@peppi-lotta
Copy link
Member Author

/test metal3-dev-env-integration-test-ubuntu-main

2 similar comments
@peppi-lotta
Copy link
Member Author

/test metal3-dev-env-integration-test-ubuntu-main

@peppi-lotta
Copy link
Member Author

/test metal3-dev-env-integration-test-ubuntu-main

@peppi-lotta peppi-lotta changed the title Test IPAM and CAPM3 changes together WIP: Change the way IPAM is deployed with CAPM3 and Test changes made in IPAM and CAPM3 together Oct 16, 2024
@metal3-io-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kashifest

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 7, 2025
@peppi-lotta peppi-lotta force-pushed the peppi-lotta/test-CAPM3-and-IPAM-changes-together branch 2 times, most recently from a982ea1 to 1df52d4 Compare January 28, 2025 11:49
@metal3-io-bot metal3-io-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 28, 2025
@peppi-lotta peppi-lotta force-pushed the peppi-lotta/test-CAPM3-and-IPAM-changes-together branch 3 times, most recently from 855c322 to f2e7bbe Compare January 29, 2025 07:18
@peppi-lotta peppi-lotta force-pushed the peppi-lotta/test-CAPM3-and-IPAM-changes-together branch 2 times, most recently from bcf832c to 84cb4c9 Compare February 19, 2025 09:33
@peppi-lotta peppi-lotta force-pushed the peppi-lotta/test-CAPM3-and-IPAM-changes-together branch from 84cb4c9 to b828e93 Compare February 20, 2025 08:24
@peppi-lotta
Copy link
Member Author

/test metal3-centos-e2e-integration-test-release-1-9

@peppi-lotta peppi-lotta force-pushed the peppi-lotta/test-CAPM3-and-IPAM-changes-together branch from b828e93 to d860667 Compare February 20, 2025 11:34
@peppi-lotta
Copy link
Member Author

/test metal3-centos-e2e-integration-test-release-1-9

@metal3-io-bot
Copy link
Collaborator

metal3-io-bot commented Feb 20, 2025 •
edited
Loading

@peppi-lotta: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
metal3-ubuntu-e2e-integration-test-main e120680 link false /test metal3-ubuntu-e2e-integration-test-main
metal3-centos-e2e-integration-test-release-1-8 31fb996 link true /test metal3-centos-e2e-integration-test-release-1-8
metal3-centos-e2e-integration-test-main 1f16610 link false /test metal3-centos-e2e-integration-test-main

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@peppi-lotta
Test IPAM and CAPM3 changes together because tests don't pass alone d…
77e86a8 
…ue to namespace name change

Signed-off-by: peppi-lotta <[email protected]>
@peppi-lotta peppi-lotta force-pushed the peppi-lotta/test-CAPM3-and-IPAM-changes-together branch from d860667 to 77e86a8 Compare February 20, 2025 12:32
@peppi-lotta
Copy link
Member Author

/hold

@metal3-io-bot metal3-io-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 20, 2025
@adilGhaffarDev
Copy link
Member

/override metal3-centos-e2e-integration-test-release-1-9 metal3-dev-env-integration-test-ubuntu-main
/lgtm

@metal3-io-bot
Copy link
Collaborator

@adilGhaffarDev: adilGhaffarDev unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file.

In response to this:

/override metal3-centos-e2e-integration-test-release-1-9 metal3-dev-env-integration-test-ubuntu-main
/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 21, 2025
@lentzi90
Copy link
Member

/override metal3-centos-e2e-integration-test-release-1-9 metal3-dev-env-integration-test-ubuntu-main

@metal3-io-bot
Copy link
Collaborator

@lentzi90: Overrode contexts on behalf of lentzi90: metal3-centos-e2e-integration-test-release-1-9, metal3-dev-env-integration-test-ubuntu-main

In response to this:

/override metal3-centos-e2e-integration-test-release-1-9 metal3-dev-env-integration-test-ubuntu-main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@peppi-lotta
Copy link
Member Author

/unhold

@metal3-io-bot metal3-io-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 25, 2025
@metal3-io-bot metal3-io-bot merged commit 6fd73c7 into metal3-io:main Feb 25, 2025
5 checks passed
@metal3-io-bot metal3-io-bot deleted the peppi-lotta/test-CAPM3-and-IPAM-changes-together branch February 25, 2025 06:41
@peppi-lotta peppi-lotta mentioned this pull request Feb 25, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kashifest kashifest kashifest left review comments

@smoshiur1237 smoshiur1237 Awaiting requested review from smoshiur1237

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@peppi-lotta @mquhuy @metal3-io-bot @adilGhaffarDev @lentzi90 @kashifest