Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VScode Emmet missing HTML "hgroup" tag #117154

Closed
DanielBailey-web opened this issue Feb 21, 2021 · 5 comments · Fixed by microsoft/vscode-emmet-helper#55
Closed

VScode Emmet missing HTML "hgroup" tag #117154

DanielBailey-web opened this issue Feb 21, 2021 · 5 comments · Fixed by microsoft/vscode-emmet-helper#55
Assignees
@rzhao271
Labels
bug Issue identified by VS Code Team member as probable bug emmet Emmet related issues insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone
March 2021

Comments

@DanielBailey-web
Copy link

It appears that emmet on vscode is missing this HTML tag (hgroup).
It is part of the living standard of HTML and therefore I think it was just overlooked (as it is rarely used.)
It is however an important tag for accessibility reasons.

Here is the MDN documentation for hgroup.
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/hgroup

I am using Ubuntu 20.04
$ code -- version 1.53.2
Extensions:
Auto Rename Tag
EJS language support
ES7 React/Redux/GraphQL/React-Native snippets
Live Server
Prettier - Code formatter
SQLTools
Template String Converter
Deno

Reproducible steps:

  1. open html document
  2. type hgroup
  3. ctrl + space (or alternative to trigger suggestions)
  4. look in horror at no suggestions

I expected to see hgroup tag suggestion that would then make it create an opening and closing tag.
@rzhao271 rzhao271 added bug Issue identified by VS Code Team member as probable bug emmet Emmet related issues good first issue Issues identified as good for first-time contributors help wanted Issues identified as good community contribution opportunities labels Feb 22, 2021
@rzhao271 rzhao271 added this to the On Deck milestone Feb 22, 2021
@rzhao271
Copy link
Contributor

Code pointer if anyone's interested: check out #114923

@OBITORASU
Copy link

@rzhao271 the approach for this issue should be identical to the approach taken for figcaption am I right? I would like to work on this one if that is the case.

@rzhao271
Copy link
Contributor

@OBITORASU yep, it should be the same.

@OBITORASU
Copy link

Thank you I will send a PR then.

@OBITORASU OBITORASU mentioned this issue Feb 23, 2021
Merged
rzhao271 pushed a commit to microsoft/vscode-emmet-helper that referenced this issue Mar 2, 2021
@OBITORASU
Fixes microsoft/vscode#117154 - VScode Emmet missing HTML "hgroup" tag (
8888243 
#55)
rzhao271 added a commit that referenced this issue Mar 2, 2021
@rzhao271
Bump Emmet yarn, fixes #117154, fixes #97632
b629d88
@rzhao271 rzhao271 modified the milestones: On Deck, March 2021 Mar 2, 2021
@rzhao271 rzhao271 removed good first issue Issues identified as good for first-time contributors help wanted Issues identified as good community contribution opportunities labels Mar 2, 2021
@rzhao271
Copy link
Contributor

rzhao271 commented Mar 2, 2021

\closedWith b629d88

@RMacfarlane RMacfarlane added the verified Verification succeeded label Mar 24, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Apr 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rzhao271 rzhao271

Labels
bug Issue identified by VS Code Team member as probable bug emmet Emmet related issues insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Milestone
March 2021
Development

Successfully merging a pull request may close this issue.

Fixes Issue 117154 - VScode Emmet missing HTML "hgroup" tag OBITORASU/vscode-emmet-helper
5 participants
@RMacfarlane @rzhao271 @DanielBailey-web @OBITORASU and others