macOS: windows no longer open in fullscreen properly anymore

[bpasero]

Steps to Reproduce:

1. be in a fullscreen window
2. Ctrl+R
3. select an entry and hold Cmd key

=> 🐛 a new window opens but not fullscreen

//cc @sandy081

[bpasero]

@deepak1556 I cannot reproduce with Electron 12.0.4 so this seems like a regression with our Electron updates. Can you please advise?

[bpasero]

I cannot reproduce in 12.0.8 so it can only be electron/electron#29235 or electron/electron#29226

[bpasero]

Pushed a workaround to open in fullscreen but there is still an issue that the window does not seem to create a space on the desktop.

[intellild]

Seems I hit github's bug
I synced the main branch to my fork and it shows that I pushed a commit referenced this issue
Please ignore it

[ryenus]

One more case with native tabs on macOS:

	"window.nativeTabs": true,
	"window.titleBarStyle": "native",

1. Open vscode as a normal window on Desktop
2. Press Cmd + Option + F to make it fullscreen with its own Space
3. Press Cmd + Option + N to open a new window
4. With 1.56, the new window would just open as a native tab, merged with existing vscode window, but with 1.57.0 there're several issues:
   a. the native tab disappears, leaving only the black background
   b. a separate blank Space is created without anything there, just the black background.

If the step 2 above is skipped, the new window opens just fine on the Desktop, merged with the existing one.

[ryenus]

One more case with native tabs on macOS:

	"window.nativeTabs": true,
	"window.titleBarStyle": "native",

1. Open vscode as a normal window on Desktop
2. Press Cmd + Option + F to make it fullscreen with its own Space
3. Press Cmd + Option + N to open a new window
4. With 1.56, the new window would just open as a native tab, merged with existing vscode window, but with 1.57.0 there're several issues:
   a. the native tab disappears, leaving only the black background
   b. a separate blank Space is created without anything there, just the black background.

If the step 2 above is skipped, the new window opens just fine on the Desktop, merged with the existing one.

@deepak1556 The above issue still exists after 3caebff

And the same with the latest main branch at time of writing this.

[deepak1556]

@ryenus thanks for checking, can you extract it to a new issue. The original issue reported here is fixed with the latest insiders.

[deepak1556]

@ryenus I just tried yours steps and unable to reproduce the issue. Can you check if I am missing anything.