Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MacOS native tabs: use vscode terminal open un-trust workspace getting wrong display when fullscreen vscode #126016

Closed
Aliveing opened this issue Jun 11, 2021 · 7 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug electron Issues and items related to Electron insiders-released Patch has been released in VS Code Insiders macos Issues with VS Code on MAC/OS X verified Verification succeeded
Milestone

Comments

@Aliveing
Copy link

Aliveing commented Jun 11, 2021

Issue Type: Bug

Here is reproduce steps:
step 1: fullscreen vscode
step 2: show terminal
step 3: run code [any path with no workspace-trust] to open a new vscode window
step4: new window will create at a new desktop, sometimes your "run terminal window" being all black, and new window has no title bar

VS Code version: Code 1.57.0 (b4c1bd0, 2021-06-09T17:22:31.215Z)
OS version: Darwin x64 20.5.0
Restricted Mode: No

System Info
Item Value
CPUs Intel(R) Core(TM) i7-4770HQ CPU @ 2.20GHz (8 x 2200)
GPU Status 2d_canvas: enabled
gpu_compositing: enabled
metal: disabled_off
multiple_raster_threads: enabled_on
oop_rasterization: enabled
opengl: enabled_on
rasterization: enabled
skia_renderer: disabled_off_ok
video_decode: enabled
webgl: enabled
webgl2: enabled
Load (avg) 10, 5, 4
Memory (System) 16.00GB (1.94GB free)
Process Argv --crash-reporter-id eea790c0-136d-4c1b-a29e-c7866504675e
Screen Reader no
VM 0%
Extensions (73)
Extension Author (truncated) Version
Bookmarks ale 13.1.0
project-manager ale 12.2.0
z-reader aoo 1.0.3
color-info bie 0.6.0
vscode-gemfile bun 0.4.0
simple-react-snippets bur 1.2.3
turbo-console-log Cha 2.1.6
gitignore cod 0.7.0
erb Cra 0.0.1
vscode-taro-snippets crp 0.0.4
vue-peek dar 1.0.2
vscode-eslint dba 2.1.22
githistory don 0.6.16
es7-react-js-snippets dsz 3.1.1
gitlens eam 11.4.1
remotehub eam 0.5.0
vscode-html-css ecm 1.10.2
LogFileHighlighter emi 2.11.0
prettier-vscode esb 6.4.0
flow-for-vscode flo 1.5.0
auto-close-tag for 0.5.10
auto-complete-tag for 0.1.0
auto-rename-tag for 0.1.6
todo-tree Gru 0.0.213
vscode-drawio hed 1.4.0
vue-snippets hol 1.0.4
minify Hoo 0.4.3
rest-client hum 0.24.5
iceworks ice 1.0.3
iceworks-app ice 1.0.0
iceworks-config-helper ice 0.5.5
iceworks-doctor ice 1.0.0
iceworks-material-helper ice 1.0.4
iceworks-project-creator ice 1.0.0
iceworks-refactor ice 1.0.0
iceworks-style-helper ice 1.0.0
iceworks-time-master ice 1.0.1
iceworks-ui-builder ice 0.3.4
comment-translate int 1.4.2
path-autocomplete ion 1.17.1
vue jcb 0.1.5
polacode-2019 jef 0.5.2
endwise kai 1.4.2
kite kit 0.147.0
evermonkey mic 2.4.5
code-beautifier mic 2.3.3
vscode-language-pack-zh-hans MS- 1.57.1
remote-containers ms- 0.183.0
remote-ssh ms- 0.65.6
remote-ssh-edit ms- 0.65.6
remote-wsl ms- 0.56.4
debugger-for-chrome msj 4.12.12
vscode-react-native msj 1.5.1
color-highlight nau 2.3.0
live-server-preview neg 0.1.4
korofileheader OBK 4.8.12
vetur oct 0.34.1
remote-vscode raf 1.1.0
vue-vscode-snippets sdr 2.2.0
code-settings-sync Sha 3.4.3
slim sia 0.1.2
code-spell-checker str 1.10.2
vscode-stylelint sty 0.86.0
polacode-fork Tox 0.6.0
codelf unb 11.7.0
vscodeintellicode Vis 1.2.14
vscode-icons vsc 11.4.0
vim vsc 1.21.1
codetour vsl 0.0.56
vscode-wakatime Wak 12.0.0
JavaScriptSnippets xab 1.8.0
local-history xyz 1.8.1
material-theme zhu 3.10.14
A/B Experiments
vsliv368:30146709
vsreu685:30147344
python383:30185418
pythonvspyt602:30300191
vspor879:30202332
vspor708:30202333
vspor363:30204092
vswsl492cf:30256860
pythonvspyt639:30300192
pythontb:30283811
pythonvspyt551cf:30311713
vspre833cf:30267465
pythonptprofiler:30281270
vshan820:30294714
pythondataviewer:30285071
vscus158cf:30286554
vscgsv2:30307504
vscorehov:30309549
vscod805:30301674
binariesv517cf:30312826

@Aliveing Aliveing changed the title MacOS: use vscode terminal create new window getting wrong display when fullscreen vscode MacOS: use vscode terminal open un-trust workspace getting wrong display when fullscreen vscode Jun 11, 2021
@bpasero
Copy link
Member

bpasero commented Jun 11, 2021

Likely #125122

@bpasero
Copy link
Member

bpasero commented Jun 11, 2021

@Aliveing do you have native macOS tabs enabled?

@bpasero bpasero added the info-needed Issue requires more information from poster label Jun 11, 2021
@Aliveing
Copy link
Author

image
Yes, I enabled it.

@ryenus
Copy link
Contributor

ryenus commented Jun 11, 2021

@bpasero see also my comment here:
#125122 (comment)

@deepak1556 deepak1556 changed the title MacOS: use vscode terminal open un-trust workspace getting wrong display when fullscreen vscode MacOS native tabs: use vscode terminal open un-trust workspace getting wrong display when fullscreen vscode Jun 11, 2021
@deepak1556 deepak1556 added bug Issue identified by VS Code Team member as probable bug macos Issues with VS Code on MAC/OS X and removed info-needed Issue requires more information from poster labels Jun 11, 2021
@deepak1556 deepak1556 added this to the June 2021 milestone Jun 11, 2021
@deepak1556 deepak1556 self-assigned this Jun 11, 2021
@bpasero
Copy link
Member

bpasero commented Jun 11, 2021

We will revert Electron via #126025 for recovery which should address this issue.

@bpasero bpasero added the electron Issues and items related to Electron label Jun 11, 2021
@bpasero bpasero removed their assignment Jun 11, 2021
@Aliveing
Copy link
Author

1.57.1 works fine, thanks a lot.

@deepak1556
Copy link
Collaborator

Reopening as we still haven't addressed the issue in insiders.

@deepak1556 deepak1556 reopened this Jun 21, 2021
@rzhao271 rzhao271 added the verified Verification succeeded label Jul 1, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Aug 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug electron Issues and items related to Electron insiders-released Patch has been released in VS Code Insiders macos Issues with VS Code on MAC/OS X verified Verification succeeded
Projects
Archived in project
Development

No branches or pull requests

6 participants
@ryenus @bpasero @deepak1556 @rzhao271 @Aliveing and others