Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.57.0 (macOS): window behaves different now (fullscreen & priority issues) #126025

Closed
bpasero opened this issue Jun 11, 2021 · 12 comments
Closed
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release electron Issues and items related to Electron verified Verification succeeded workbench-os-integration Native OS integration issues

Comments

@bpasero
Copy link
Member

bpasero commented Jun 11, 2021

We are seeing increased number of issues on macOS regarding VSCode window not behaving like before. This is likely a regression from https://github.com/electron/electron/pull/29235/files

This is a revert to Electron 12.0.7 and a revert of a commit I had pushed as workaround for this issue.

Workaround: none today, you can go back to 1.56.2 via download and configure update.mode to none or manual.

//cc @deepak1556

@bpasero bpasero added the candidate Issue identified as probable candidate for fixing in the next release label Jun 11, 2021
@bpasero bpasero self-assigned this Jun 11, 2021
@bpasero bpasero added this to the May 2021 Recovery milestone Jun 11, 2021
@bpasero bpasero added electron Issues and items related to Electron workbench-os-integration Native OS integration issues bug Issue identified by VS Code Team member as probable bug labels Jun 11, 2021
@ryenus
Copy link
Contributor

ryenus commented Jun 11, 2021

Workaround: none today, you can go back to 1.56.2 via download

Maybe it's obvious, I had to disable automatic update by setting update.mode to none or manual.

@bpasero bpasero changed the title Revert back to Electron 12.0.7 macOS: window behaves different in 1.57 (fullscreen & priority issues) Jun 11, 2021
@bpasero bpasero pinned this issue Jun 11, 2021
@bpasero bpasero changed the title macOS: window behaves different in 1.57 (fullscreen & priority issues) 1.57.0 (macOS): window behaves different now (fullscreen & priority issues) Jun 11, 2021
@bpasero bpasero closed this as completed Jun 14, 2021
@jamesb93
Copy link

I use Alfred to move between applications and currently VSCODE will retake control of priority whenever I use their spotlight replacement to change applications.

@jacobweber
Copy link

jacobweber commented Jun 14, 2021

I'm guessing this is related to why command-H no longer hides VS Code some of the time? Seems to behave differently depending on which workspace window is open. This is on 1.57.0.

Never mind; looks like a Git Graph issue.

@jamesb93
Copy link

I'm guessing this is related to why command-H no longer hides VS Code some of the time? Seems to behave differently depending on which workspace window is open. This is on 1.57.0.

I always work in a workspace. Does it depend on whether or not you are in a workspace at all, or just on the workspace itself?

@jacobweber
Copy link

jacobweber commented Jun 14, 2021

I always work in a workspace. Does it depend on whether or not you are in a workspace at all, or just on the workspace itself?

I didn't think there was a way to NOT be in a workspace, other than having all windows closed. But I'm generally working in single-folder workspaces. Anyway, it seems to depend on the particular window -- I have two open, and it's only happening when a certain one is in front. But if I close and reopen that one, it doesn't start happening for a while. If this upcoming recovery doesn't fix it, I'll try to narrow down the cause a little more.

@dennis-damico
Copy link

dennis-damico commented Jun 14, 2021

VSCODE will retake control of priority

I'm having the same issue when trying to switch applications with alt tab

@tricktron
Copy link

tricktron commented Jun 15, 2021

I downgraded to 1.56.2 and started vs-code from command line with code --disable-extensions .

Result: I can't render/show any files anymore:
error-screenshot

The following warnings are shown in the developer console:

ERR (this.configurationService.getValue(...) || []).filter is not a function: TypeError: (this.configurationService.getValue(...) || []).filter is not a function

When I create a new file test2.txt I get the same error again.

Here you have the full log.

I am on Big Sur 11.4 and

Version: 1.56.2
Commit: 054a9295330880ed74ceaedda236253b4f39a335
Date: 2021-05-12T17:44:30.902Z (1 mo ago)
Electron: 12.0.4
Chrome: 89.0.4389.114
Node.js: 14.16.0
V8: 8.9.255.24-electron.0
OS: Darwin x64 20.5.0

Edit/Solution

Solved in #123749 (comment)

@abdel-ships-it
Copy link

abdel-ships-it commented Jun 16, 2021

Yeah this issue is frustrating, the native tabs feature seems to be broken in the last upgrade. Every time I open a new window I get a new macOS space automatically opened

Edit: Disabling the native full screen setting seems to fix it for me.

image

@lramos15 lramos15 added the verified Verification succeeded label Jun 16, 2021
@lehungdev
Copy link

Yeah this issue is frustrating, the native tabs feature seems to be broken in the last upgrade. Every time I open a new window I get a new macOS space automatically opened

Edit: Disabling the native full screen setting seems to fix it for me.

image

Yes, I had to revert to the old version because of this error.

@uphlewis
Copy link

uphlewis commented Jun 17, 2021

I get the same issue using contexts to cmd + tab between windows on Catalina 10.15.7 (19H1217). VSCode just switches back to the front again. It seems inconsistent, i.e sometimes it doesnt do it. Super strange.

Version: 1.57.0
Commit: b4c1bd0a9b03c749ea011b06c6d2676c8091a70c
Date: 2021-06-09T17:22:31.215Z
Electron: 12.0.9
Chrome: 89.0.4389.128
Node.js: 14.16.0
V8: 8.9.255.25-electron.0
OS: Darwin x64 19.6.0

@bpasero bpasero unpinned this issue Jun 18, 2021
@Borongaj
Copy link

Borongaj commented Jun 18, 2021

On macOS : VSCode 1.57.1 start, black screen, and close...

Edit : I had to start VSCode from command line. First try : same problem. Second try : VSCode 1.57.1 works.

@uphlewis
Copy link

Appears fixed on 1.57.1 thanks everyone

@github-actions github-actions bot locked and limited conversation to collaborators Jul 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release electron Issues and items related to Electron verified Verification succeeded workbench-os-integration Native OS integration issues
Projects
None yet
Development

No branches or pull requests