-
Notifications
You must be signed in to change notification settings - Fork 31k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Killing tasks does not actually kill them #242891
Comments
Facing this issue too =( I can get around it with Edit: Found a faster way to close hanging ports, just run |
@deepak1556 or @Tyriar nothing has changed with tasks in recent iterations that could explain this. Are you aware of any node pty changes or other that could? |
Yeah very likely related to #242942 (comment), will check. |
Can users share a sample task configuration that repros this issue, tested with the following
Killing the terminal kills the task without issues. |
{
"version": "2.0.0",
"tasks": [
{
"label": "npm: dev",
"type": "npm",
"script": "dev",
// "isBackground": true,
"presentation": {
"panel": "dedicated",
"reveal": "silent"
},
"runOptions": {
"runOn": "folderOpen"
},
"problemMatcher": []
}
]
} I removed |
Not sure if it related to VSCode directly. But facing this issue from last week. So annoying. |
We're having trouble reproducing the issue. To help us narrow down what change caused the issue, please run the following command to find the build. It will start previous releases of VS Code insiders to see where the regression was introduced:
Thanks! |
Can users check if the issue is fixed in latest insiders https://code.visualstudio.com/insiders with |
Version: 1.99.0-insider (user setup) | Version: 1.98.1 (user setup) Commit: c1fb4c3 Not fixed. Steps to reproduce (in my case): Tested with and without !!! New important info: Temporary workaround: "Do not click kill button, use ctrl+c" Results: |
@alikil thanks for checking, this was with Can you provide the results of #242891 (comment), it would help us narrow down the regression. |
Same behaviour for me when tasks are killed via command palette |
@capc0 Can you provide the results of #242891 (comment)? |
I cant reproduce the behaviour within the |
Link to github after full test. ( |
Type: Bug
When I kill a task in the terminal tab, it gets removed from the lists of running tasks, however starting in one of the recent code versions (probably 1.98.0?), the task does not get killed and is still runing in the background and can also still be found in the windows task manager.
Example: vite dev/hot server. Everytime I kill a server task, it keeps on running. The next time I start it, the used port number will increase due to the previous one still being in use.
VS Code version: Code 1.98.0 (6609ac3, 2025-03-04T21:06:18.612Z)
OS version: Windows_NT x64 10.0.26100
Modes:
System Info
canvas_oop_rasterization: enabled_on
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: enabled
multiple_raster_threads: enabled_on
opengl: enabled_on
rasterization: enabled
raw_draw: disabled_off_ok
skia_graphite: disabled_off
video_decode: enabled
video_encode: enabled
vulkan: disabled_off
webgl: enabled
webgl2: enabled
webgpu: enabled
webnn: disabled_off
Extensions (14)
The text was updated successfully, but these errors were encountered: