Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Kill Terminal] Sometime can not type #242942

Closed
kaitoukid-1412 opened this issue Mar 8, 2025 · 14 comments · Fixed by #243267
Closed

[Kill Terminal] Sometime can not type #242942

kaitoukid-1412 opened this issue Mar 8, 2025 · 14 comments · Fixed by #243267
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders regression Something that used to work is now broken under-discussion Issue is under discussion for relevance, priority, approach
Milestone

Comments

@kaitoukid-1412
Copy link

Does this issue occur when all extensions are disabled?: Yes/No

  • VS Code Version: 1.98.0
  • OS Version: w11

Steps to Reproduce:

  1. Kill all terminal and close Vscode
  2. Open VSCode
  3. Open terminal
  4. Kill terminal
  5. Open terminal again and type
@kaitoukid-1412
Copy link
Author

{
  "editor.codeActionsOnSave": {
    "source.fixAll": "explicit",
    "source.organizeImports": "explicit"
  },
  "diffEditor.ignoreTrimWhitespace": true,
  "editor.cursorSmoothCaretAnimation": "on",
  "editor.defaultFormatter": "esbenp.prettier-vscode",
  "editor.dragAndDrop": false,
  "editor.fontFamily": "Hubot Sans",
  "editor.fontSize": 13,
  "editor.formatOnSave": true,
  "editor.guides.bracketPairs": "active",
  "editor.guides.indentation": false,
  "editor.minimap.enabled": false,
  "editor.semanticHighlighting.enabled": true,
  "editor.smoothScrolling": true,
  "editor.stickyScroll.enabled": false,
  "errorLens.fontStyleItalic": true,
  "explorer.excludeGitIgnore": true,
  "explorer.fileNesting.enabled": true,
  "explorer.fileNesting.expand": false,
  "git.confirmSync": false,
  "git.postCommitCommand": "push",
  "javascript.inlayHints.parameterNames.enabled": "all",
  "terminal.integrated.fontFamily": "Consolas",
  "terminal.integrated.shellIntegration.decorationsEnabled": "never",
  "window.commandCenter": false,
  "workbench.editor.enablePreview": false,
  "workbench.iconTheme": "vscode-icons",
  "workbench.layoutControl.enabled": false,
  "workbench.productIconTheme": "material-product-icons",
  "workbench.startupEditor": "none",
  "workbench.colorTheme": "Vespertino",
  "diffEditor.useInlineViewWhenSpaceIsLimited": false,
  "workbench.sideBar.location": "right"
}

@kaitoukid-1412
Copy link
Author

kaitoukid-1412 commented Mar 8, 2025

Image
Image

If the terminal is started from the menu, there will be no problem

@ericchase
Copy link

ericchase commented Mar 8, 2025

confirming. quite frustrating, how do we disable all the new features you guys added to the terminal? i just want it to work as it always has

anyone who doesn't want to wait, you can go back to the previous version which doesn't have this bug (as far as i can tell)
https://code.visualstudio.com/updates/v1_97

for Windows system installer, copy one of the download links and remove the -user near the end
i.e.
https://update.code.visualstudio.com/1.97.2/win32-x64-user/stable
-> https://update.code.visualstudio.com/1.97.2/win32-x64/stable

@kaitoukid-1412
Copy link
Author

@ericchase thanks

@DanKaplanSES
Copy link

DanKaplanSES commented Mar 8, 2025

I am also experiencing this. I'm using a cygwin integrated terminal. Once (but never again) I had an yellow/orange/red (can't remember) icon on my status bar that said something related to pty. I found this older SO post but I doubt there is any information in there that'll help this time around. I did not experience what's shown in that screenshot, but it's describing the same symptoms.

Unlike @kaitoukid-1412 , I can't consistently reproduce this, but it is frequent enough to make the integrated terminal effectively unusable. >50% of the time I kill and start a cygwin terminal in vscode, or I run a command in my cygwin terminal, the terminal freezes.

I tried deleting my local project's .vscode dir, but that did not fix the problem.

I tried deleting my entire AppData\Roaming\Code directory, but I could still reproduce the problem with powershell.

HTH

PS: I have confirmed that downgrading my VS Code version to 1.97.2 fixes the issue.

@albertosantini
Copy link

Try "terminal.integrated.windowsUseConptyDll": true

@jeanp413
Copy link
Contributor

jeanp413 commented Mar 9, 2025

Regression from #241115
cc @deepak1556

@deepak1556
Copy link
Collaborator

@jeanp413 was the commit found via bisect ? The changes in that PR should only affect "terminal.integrated.windowsUseConptyDll" which is disabled by default in stable.

@deepak1556
Copy link
Collaborator

If this is a confirmed regression, it would help to know which change caused it. We maintain a node.js based CLI tool vscode-bisect that automatically downloads and runs previous VS Code insiders and asks for each build if the issue reproduces. It takes up to 8 steps to find exactly the build that caused the regression.

Steps:

  • install node.js (if not yet done)
  • npx --yes @vscode/vscode-bisect@latest
  • follow the instructions until you found the offending build (its fine to leave the commit empty)
  • report back the commit range in this issue

Thanks!

@deepak1556 deepak1556 assigned deepak1556 and Tyriar and unassigned meganrogge Mar 10, 2025
@deepak1556 deepak1556 added bug Issue identified by VS Code Team member as probable bug under-discussion Issue is under discussion for relevance, priority, approach regression Something that used to work is now broken labels Mar 10, 2025
@jeanp413
Copy link
Contributor

jeanp413 commented Mar 10, 2025

@deepak1556 I run vscode from sources and reverted that PR, works fine using the older version of node-pty

@deepak1556
Copy link
Collaborator

@jeanp413 if you had a consistent repro can you please share, I am unable to repro this issue with the steps provided from #242942 (comment).

@jeanp413
Copy link
Contributor

jeanp413 commented Mar 11, 2025

Not really specific steps, basically the same as OP:

  1. Create terminal
  2. Start typing and after a few seconds it will die with terminated with exit code: -1073741510
  3. If it doesn't, kill that terminal manually and repeat again from step 1

@deepak1556
Copy link
Collaborator

Thanks! I was able to repro #242850 and believe the root issue to be the same for this one. Fix up microsoft/node-pty#766

@vs-code-engineering vs-code-engineering bot added the unreleased Patch has not yet been released in VS Code Insiders label Mar 12, 2025
@vs-code-engineering vs-code-engineering bot added this to the March 2025 milestone Mar 12, 2025
@vs-code-engineering vs-code-engineering bot added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Mar 12, 2025
@deepak1556
Copy link
Collaborator

Can users check if the issue is fixed in latest insiders https://code.visualstudio.com/insiders with "terminal.integrated.windowsUseConptyDll": false setting ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders regression Something that used to work is now broken under-discussion Issue is under discussion for relevance, priority, approach
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants