-
Notifications
You must be signed in to change notification settings - Fork 31k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Kill Terminal] Sometime can not type #242942
Comments
{
"editor.codeActionsOnSave": {
"source.fixAll": "explicit",
"source.organizeImports": "explicit"
},
"diffEditor.ignoreTrimWhitespace": true,
"editor.cursorSmoothCaretAnimation": "on",
"editor.defaultFormatter": "esbenp.prettier-vscode",
"editor.dragAndDrop": false,
"editor.fontFamily": "Hubot Sans",
"editor.fontSize": 13,
"editor.formatOnSave": true,
"editor.guides.bracketPairs": "active",
"editor.guides.indentation": false,
"editor.minimap.enabled": false,
"editor.semanticHighlighting.enabled": true,
"editor.smoothScrolling": true,
"editor.stickyScroll.enabled": false,
"errorLens.fontStyleItalic": true,
"explorer.excludeGitIgnore": true,
"explorer.fileNesting.enabled": true,
"explorer.fileNesting.expand": false,
"git.confirmSync": false,
"git.postCommitCommand": "push",
"javascript.inlayHints.parameterNames.enabled": "all",
"terminal.integrated.fontFamily": "Consolas",
"terminal.integrated.shellIntegration.decorationsEnabled": "never",
"window.commandCenter": false,
"workbench.editor.enablePreview": false,
"workbench.iconTheme": "vscode-icons",
"workbench.layoutControl.enabled": false,
"workbench.productIconTheme": "material-product-icons",
"workbench.startupEditor": "none",
"workbench.colorTheme": "Vespertino",
"diffEditor.useInlineViewWhenSpaceIsLimited": false,
"workbench.sideBar.location": "right"
}
|
confirming. quite frustrating, how do we disable all the new features you guys added to the terminal? i just want it to work as it always has anyone who doesn't want to wait, you can go back to the previous version which doesn't have this bug (as far as i can tell) for Windows system installer, copy one of the download links and remove the |
@ericchase thanks |
I am also experiencing this. I'm using a cygwin integrated terminal. Once (but never again) I had an yellow/orange/red (can't remember) icon on my status bar that said something related to pty. I found this older SO post but I doubt there is any information in there that'll help this time around. I did not experience what's shown in that screenshot, but it's describing the same symptoms. Unlike @kaitoukid-1412 , I can't consistently reproduce this, but it is frequent enough to make the integrated terminal effectively unusable. >50% of the time I kill and start a cygwin terminal in vscode, or I run a command in my cygwin terminal, the terminal freezes. I tried deleting my local project's .vscode dir, but that did not fix the problem. I tried deleting my entire HTH PS: I have confirmed that downgrading my VS Code version to 1.97.2 fixes the issue. |
Try |
Regression from #241115 |
@jeanp413 was the commit found via bisect ? The changes in that PR should only affect |
If this is a confirmed regression, it would help to know which change caused it. We maintain a node.js based CLI tool Steps:
Thanks! |
@deepak1556 I run vscode from sources and reverted that PR, works fine using the older version of node-pty |
@jeanp413 if you had a consistent repro can you please share, I am unable to repro this issue with the steps provided from #242942 (comment). |
Not really specific steps, basically the same as OP:
|
Thanks! I was able to repro #242850 and believe the root issue to be the same for this one. Fix up microsoft/node-pty#766 |
Can users check if the issue is fixed in latest insiders https://code.visualstudio.com/insiders with |
Does this issue occur when all extensions are disabled?: Yes/No
Steps to Reproduce:
The text was updated successfully, but these errors were encountered: