-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#126] Add mount integration #127
[#126] Add mount integration #127
Conversation
- Add new `formatting-stack.mount` namespace for configuring `on-up` hooks - Add mount tests and example repl/dev implementation
cedca68
to
af13ebb
Compare
I'm not seeing a build spin up, so I haven't checked that box. However, tests do pass locally. |
👍! I appreciate the care being placed. Sometime soon I'll merge this directly (to a branch other than Thanks for the contribution! |
My pleasure! I use |
:in-background? false | ||
:reporter (reporters.passthrough/new)}] | ||
(sut/configure opts) | ||
(mount/start) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would help me to understand - can (mount/start)
perform code-loading (like a clojure.core/require
or a tools.namespace.repl/refresh
)?
If that were the case, this test would be unlike its Component and Integrant cousins
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mount/start
isn't really smart in-and-of-itself, it really just calls :start
on all the defstates
that it knows about.
However, mount
automatically handles re-compilation (basically just (mount/stop) (mount/start)
) of its defstates
whenever a namespace is recompiled.
So if someone ran (require ... :reload)
or ran C-c C-k
in a CIDER repl on a namespace with a defstate
, all hooks would be called.
Merging against |
formatting-stack.mount
namespace for configuringon-up
hooks
Brief
#126
QA plan
Green tests
Author checklist
Reviewer checklist