Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for mount #126

Open
bn-darindouglass-zz opened this issue Feb 21, 2020 · 0 comments
Open

Add support for mount #126

bn-darindouglass-zz opened this issue Feb 21, 2020 · 0 comments

Comments

@bn-darindouglass-zz
Copy link

Context

Currently formatting-stack supports Component and Integrant hooks. mount is another popular state-management library that would be easily supported.

Task

Add new formatting-stack.mount namespace that adds mount-up/on-up hooks for formatting code.

Acceptance criteria

Mount is pluggable.

Additional resources

The mount-up library will work easily for adding this hook. Something small like should suffice:

(speced/defn start [^map? this]
  ...)

(mu/on-up :formatting start :after)
bn-darindouglass-zz pushed a commit to bn-darindouglass-zz/formatting-stack that referenced this issue Feb 21, 2020
@barracudarin
[nedap#126] Add mount integration
cedca68 
- Add new `formatting-stack.mount` namespace for configuring `on-up`
  hooks
- Add mount tests and example repl/dev implementation
@bn-darindouglass-zz bn-darindouglass-zz mentioned this issue Feb 21, 2020
Merged
28 tasks
bn-darindouglass-zz pushed a commit to bn-darindouglass-zz/formatting-stack that referenced this issue Feb 21, 2020
@barracudarin
[nedap#126] Add mount integration
3429f28 
- Add new `formatting-stack.mount` namespace for configuring `on-up`
  hooks
- Add mount tests and example repl/dev implementation
bn-darindouglass-zz pushed a commit to bn-darindouglass-zz/formatting-stack that referenced this issue Feb 21, 2020
@barracudarin
[nedap#126] Update README with mount info
af13ebb
vemv added a commit that referenced this issue Feb 22, 2020
@vemv
Merge pull request #127 from DarinDouglass/126-add-mount-integration
6a5a1c7 
[#126] Add mount integration
bn-darindouglass-zz pushed a commit to bn-darindouglass-zz/formatting-stack that referenced this issue Feb 25, 2020
@barracudarin
[nedap#126] Remove mount/args support
db9c2ab 
- While potentially handy in some cases, most often the dual (and
  independent) configuration's for mount can get confusing.
thumbnail added a commit that referenced this issue Feb 25, 2020
@thumbnail
Merge pull request #135 from DarinDouglass/mount-v2
b135ce1 
[#126] Remove mount/args support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bn-darindouglass-zz