Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#126] Remove mount/args support #135

Merged
merged 2 commits into from
Feb 25, 2020

Conversation

bn-darindouglass-zz
Copy link

@bn-darindouglass-zz bn-darindouglass-zz commented Feb 25, 2020

  • While potentially handy in some cases, most often the dual (and
    independent) configuration's for mount can get confusing.

QA plan

Green tests

Author checklist

  • I have QAed the functionality
  • The PR has a reasonably reviewable size and a meaningful commit history
  • I have run the branch formatter and observed no new/significative warnings
  • The build passes
  • I have self-reviewed the PR prior to assignment
  • Additionally, I have code-reviewed iteratively the PR considering the following aspects in isolation:
    • Correctness
    • Robustness (red paths, failure handling etc)
    • Modular design
    • Test coverage
    • Spec coverage
    • Documentation
    • Security
    • Performance
    • Breaking API changes
    • Cross-compatibility (Clojure/ClojureScript)

Reviewer checklist

  • I have checked out this branch and reviewed it locally, running it
  • I have QAed the functionality
  • I have reviewed the PR
  • Additionally, I have code-reviewed iteratively the PR considering the following aspects in isolation:
    • Correctness
    • Robustness (red paths, failure handling etc)
    • Modular design
    • Test coverage
    • Spec coverage
    • Documentation
    • Security
    • Performance
    • Breaking API changes
    • Cross-compatibility (Clojure/ClojureScript)

- While potentially handy in some cases, most often the dual (and
  independent) configuration's for mount can get confusing.
@bn-darindouglass-zz bn-darindouglass-zz mentioned this pull request Feb 25, 2020
28 tasks
@vemv
Copy link
Contributor

vemv commented Feb 25, 2020

Thanks for this one!

There's a merge conflict

@bn-darindouglass-zz
Copy link
Author

Resolved.

@thumbnail thumbnail merged commit b135ce1 into nedap:126--mount Feb 25, 2020
@bn-darindouglass-zz bn-darindouglass-zz deleted the mount-v2 branch February 25, 2020 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants