Fix misuse of outdated variable that led to an impossible condition #1416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes a local counter used as an exit condition for a while true loop that was never increased. It is replaced by using the correct functions of send_buffer_positions.
terhorstd
added
ZC: Kernel
heplesser
approved these changes
Feb 19, 2020
|
Reviewed in VC by @suku248, @terhorstd, @heplesser , thus merging without further review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes a local counter used as an exit condition for a while true loop that was never increased. It is replaced by using the correct functions of send_buffer_positions. While this should not lead to any bugs, it potentially slows down construction of the presynaptic infrastructure quite severely.
Discovered during a code review session with @suku248 @diesmann @heplesser