Refactor SendBufferPosition, fail on query with rank outside of range #1421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakobj
commented
Feb 10, 2020
| @@ -110,6 +114,8 @@ inline SendBufferPosition::SendBufferPosition( const AssignedRanks& assigned_ran | |||
| inline thread | |||
| SendBufferPosition::rank_to_index_( const thread rank ) const | |||
| { | |||
| assert( begin_rank_ <= rank ); | |||
There was a problem hiding this comment.
these are the important asserts
terhorstd
added
ZC: Kernel
heplesser
approved these changes
Feb 19, 2020
|
Reviewed in VC by @suku248, @terhorstd, @heplesser, merging without further review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During code review with @suku248 we realized one could query the
SendBufferPositionwith ranks that are outside of the range for which a specific thread is responsible, returning nonsense values due to modulo arithmetic. This PR addresses that issue by adding two specific asserts.Depends on #1416, should be merged after.
@hakonsbm @heplesser @jougs @stinebuu @jarsi