Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Set CURLOPT_USERAGENT for Scraper #2380

Merged
merged 3 commits into from
Oct 19, 2023
Merged

Conversation

IgorA100
Copy link
Contributor

@IgorA100 IgorA100 commented Oct 14, 2023

Some sites do not serve content without a User Agent

Summary

Set CURLOPT_USERAGENT= FetcherConfig::DEFAULT_USER_AGENT

Checklist

Some sites do not serve content without a User Agent
Set CURLOPT_USERAGENT= Google Chrome

Signed-off-by: IgorA100 <[email protected]>
Use FetcherConfig::DEFAULT_USER_AGENT for Curl

Signed-off-by: IgorA100 <[email protected]>
Copy link
Contributor

@SMillerDev SMillerDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add an item to the CHANGELOG file

@IgorA100 IgorA100 changed the title Fix: Set CURLOPT_USERAGENT Fix: Set CURLOPT_USERAGENT for Scraper Oct 16, 2023
- Set User Agent for curl in Scraper

Signed-off-by: IgorA100 <[email protected]>
@IgorA100
Copy link
Contributor Author

Please also add

Ready.

@Grotax Grotax merged commit d423ca5 into nextcloud:master Oct 19, 2023
Grotax added a commit that referenced this pull request Oct 24, 2023
Changed
- Major Rewrite of the Frontend with Vue JS (#748)
  For comments and suggestions for the new UI, please use this: #2388
- Set User Agent for curl in Scraper (#2380)
- Drop support for Nextcloud 26, Supported 27

Signed-off-by: Benjamin Brahmer <[email protected]>
@Grotax Grotax mentioned this pull request Oct 24, 2023
Grotax added a commit that referenced this pull request Oct 25, 2023
Changed
- Major Rewrite of the Frontend with Vue JS (#748)
  For comments and suggestions for the new UI, please use this: #2388
- Set User Agent for curl in Scraper (#2380)
- Drop support for Nextcloud 26, Supported 27

Signed-off-by: Benjamin Brahmer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants