Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Set CURLOPT_USERAGENT for Scraper #2380

Merged
merged 3 commits into from
Oct 19, 2023
Merged

Fix: Set CURLOPT_USERAGENT for Scraper #2380

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
66f501e
Fix: Set CURLOPT_USERAGENT
IgorA100 Oct 14, 2023
1667d24
Update Scraper.php
IgorA100 Oct 15, 2023
d8052ab
Update CHANGELOG.md
IgorA100 Oct 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,8 @@ The format is mostly based on [Keep a Changelog](https://keepachangelog.com/en/1
# Unreleased
## [24.x.x]
### Changed

- Set User Agent for curl in Scraper

### Fixed

# Releases
Expand Down
3 changes: 2 additions & 1 deletion lib/Scraper/Scraper.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
use fivefilters\Readability\ParseException;
use League\Uri\Exceptions\SyntaxError;
use Psr\Log\LoggerInterface;
use OCA\News\Config\FetcherConfig;

class Scraper implements IScraper
{
Expand All @@ -37,7 +38,7 @@ public function __construct(LoggerInterface $logger)
CURLOPT_RETURNTRANSFER => true, // return web page
CURLOPT_HEADER => false, // do not return headers
CURLOPT_FOLLOWLOCATION => true, // follow redirects
//CURLOPT_USERAGENT => "php-news", // who am i
CURLOPT_USERAGENT => FetcherConfig::DEFAULT_USER_AGENT, // who am i
CURLOPT_AUTOREFERER => true, // set referer on redirect
CURLOPT_CONNECTTIMEOUT => 120, // timeout on connect
CURLOPT_TIMEOUT => 120, // timeout on response
Expand Down