Measurements schema #859
Merged
Measurements schema #859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #859 +/- ##
==========================================
- Coverage 34.32% 34.31% -0.02%
==========================================
Files 41 41
Lines 5931 5937 +6
Branches 1518 1518
==========================================
+ Hits 2036 2037 +1
- Misses 3813 3818 +5
Partials 82 82
Continue to review full report at Codecov.
|
tsibley
approved these changes
Mar 4, 2022
augur/validate.py
Outdated
| @@ -132,6 +139,8 @@ def register_arguments(parser): | |||
| subparsers.add_parser("auspice-config-v2", help="validate auspice config intended for `augur export v2`") \ | |||
| .add_argument('config_json', metavar='JSON', help="auspice config JSON") | |||
|
|
|||
| subparsers.add_parser("measurements", help="validate measuremens JSON intended for auspice measurements panel") \ | |||
augur/data/schema-measurements.json
Outdated
Comment on lines
140
to
143
| "patternProperties": { | ||
| "^.*$": { | ||
| "description": "Metadata associated with the measurement. Only metadata properties included in the groupings config will be included in the group by dropdown, but all metadata properties will be available as a filter", | ||
| "type": ["string", "number", "boolean"] | ||
| } | ||
| } |
There was a problem hiding this comment.
Suggested change
| "patternProperties": { | |
| "^.*$": { | |
| "description": "Metadata associated with the measurement. Only metadata properties included in the groupings config will be included in the group by dropdown, but all metadata properties will be available as a filter", | |
| "type": ["string", "number", "boolean"] | |
| } | |
| } | |
| "additionalProperties": { | |
| "description": "Metadata associated with the measurement. Only metadata properties included in the groupings config will be included in the group by dropdown, but all metadata properties will be available as a filter", | |
| "type": ["string", "number", "boolean"] | |
| } |
Based on the data structure that Auspice version 2.34.0 expects for the measurements sidecar JSON.
Validates the provided measurements JSON against the JSON schema `augur/data/schema-measurements.json`
joverlee521
force-pushed
the
measurements-schema
branch
from
8817c9b to
bcd36df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add measurements JSON schema and add as a subcommand to
augur validate.Schema file name matches the file name for the redirect in nextstrain/nextstrain.org#481
I'm expecting the new
augur measurementscommand to be a bigger change requiring additional discussion and reviews, so I'll leave that for a later PR.