Measurements sidecar #481
Merged
Measurements sidecar #481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Tested the charon endpoints via http://localhost:5000/charon/getDataset?prefix=community/joverlee521/nextstrain-testing/flu/seasonal/h1n1pdm/ha/09-17&type=measurements ✅
joverlee521
force-pushed
the
measurements-sidecar
branch
from
3f260f2 to
f4c7872
Compare
|
Rebased onto the auspice release, so now the testing app can displays the measurements panel. |
This was referenced Mar 3, 2022
tsibley
approved these changes
Mar 4, 2022
There was a problem hiding this comment.
👍 FWIW, the first three commits feel like they should be lumped together to me since they're all dealing with the same thing: accounting for a new sidecar type by adding the "measurements" key places. But not a big deal at all and certainly not a must.
Would you also update our data formats page?
1. Exclude "*_measurements.json" files from search scripts 2. Add "measurements" to subresource types & sidecar files 3. Add "measurements" subresource type to API endpoints
Currently gets redirected to a 404 page, but will soon be added as a JSON schema in augur.
joverlee521
force-pushed
the
measurements-sidecar
branch
from
f4c7872 to
a342882
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds "measurements" as a subresource type & sidecar file.
I searched for "tip-frequencies" within the repo and added "measurements" to the appropriate places.