-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use GitHub Actions in release process #904
Conversation
Could this also update https://github.com/nextstrain/augur/releases? Latest version there is 6.3 😬 |
That would be super cool. Then we could also show releases on the GitHub
front page again 🤓
…On Tue, Apr 26, 2022, 03:10 james hadfield ***@***.***> wrote:
Could this also update https://github.com/nextstrain/augur/releases?
Latest version there is 6.3 😬
—
Reply to this email directly, view it on GitHub
<#904 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AF77AQKMW3CGGCS47EWG2TTVG47BFANCNFSM5UKGWD6A>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
@jameshadfield @corneliusroemer I'd love to see that updated too. I've created a separate issue for that, since it's related but independent from this PR which is just automating the current process. See #907 |
bd806dc
to
6fd5259
Compare
- Replace `setup.py sdist bdist_wheel` with `build` - This is the recommended way of doing things with https://packaging.python.org/tutorials/packaging-projects/#generating-distribution-archives - Remove setup.py clean - This seems to just remove the build subdirectory. Remove it in the `rm` command. - Update `rm -rfv` command - Remove `build/` - Fix `augur.egg-info` -> `nextstrain_augur.egg-info` - Use / to denote directories
This reduces but does not completely eliminate manual work in the release process.
This looks excellent, @victorlin! I especially love the updated developer docs for the release process. A lot of these steps only lived in your head and mine until now. :D When we make the next release, can we do it as a small group (with whoever else is also interested) to see what the process through GitHub Actions looks/feels like? |
@huddlej yes, let's do that! Since there is already a bug fix queued up in https://github.com/nextstrain/augur/milestone/31, we can do a small release sometime this week. |
Noting here that we forgot a step of adding the nextstrain-bot PyPI user as a maintainer on the PyPI project. Need to remember that for any future release automation work. |
Description of proposed changes
Similar to the publish workflow for nextstrain-sphinx-theme.
Reduces but does not completely eliminate manual work in the release process. See updated release steps.
Related issue(s)
N/A
Testing
On my fork repo, I uploaded 15.0.1 to TestPyPI using these changes + a cherry-picked ed8ed92 (see successful run). I already released 15.0.1 to PyPI using current manual steps, but this can be used for the next release once merged.