Skip to content

Commit

Permalink
chore(ci): attempt to fix git tags for web
Browse files Browse the repository at this point in the history
  • Loading branch information
@ivan-aksamentov
ivan-aksamentov committed May 22, 2022
1 parent d6f2706 commit 9e860b4
Showing 1 changed file with 7 additions and 1 deletion.
8 changes: 7 additions & 1 deletion .circleci/config.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -345,8 +345,12 @@ jobs:
name: " [ web ] | Create and push git tag"
command: |
curl -fsSL "https://github.com/cli/cli/releases/download/v2.10.1/gh_2.10.1_linux_amd64.tar.gz" | tar xz -C "${HOME}/bin" --strip-components=2 gh_2.10.1_linux_amd64/bin/gh
gh auth setup-git

This comment has been minimized.

Sign in to view

Copy link
@victorlin

victorlin May 27, 2022

Member

While we're here, how does gh auth setup-git work with CircleCI? Is there a GITHUB_TOKEN defined somewhere else?
git config user.email "[email protected]"
git config user.name "nextstrain-bot"

This comment has been minimized.

Sign in to view

Copy link
@victorlin

victorlin May 27, 2022

Member

@ivan-aksamentov is [email protected] an actual address? I used hello@ for Augur.

This comment has been minimized.

Sign in to view

Copy link
@ivan-aksamentov

ivan-aksamentov May 27, 2022

Author Member

@victorlin Nope. I did not want to expose hello, because too much spam. The address does not matter here anyways.

This comment has been minimized.

Sign in to view

Copy link
@victorlin

victorlin May 27, 2022

Member

That was my thinking too, see nextstrain/augur#904 (comment)

I guess this is just pushing a tag, does the config get exposed anywhere? For commits, I assume it has to be an address linked to the nextstrain-bot user to get something like nextstrain/augur@8014186:

commit-associated-with-nextstrain-bot

This comment has been minimized.

Sign in to view

Copy link
@ivan-aksamentov

ivan-aksamentov May 27, 2022

Author Member

does the config get exposed anywhere

Well, it's in public view on GitHub and email is easily greppable.

For tags in Nextclade the email does not matter, but for pretty commits in Augur probably do.

Not a big deal. And if exposed, then what if we receive a really nice discount on luminescent lamps or bicycles, or an opportunity to act as transfer account of the inheritance of a newly crowned African prince, for a fee. It's a win-win either way! ;)
cd packages_rs/nextclade-web
export version=$(node -e "\
Expand Down Expand Up @@ -440,7 +444,9 @@ workflows:
- Build-And-Deploy-Web:
<<: *web_branches

context: nextclade_web_<< pipeline.git.branch >>
context:
- nextclade_github
- nextclade_web_<< pipeline.git.branch >>

requires:
- Update-Builder-Container

1 comment on commit 9e860b4

@vercel
Copy link

@vercel vercel bot commented on 9e860b4 May 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successfully deployed to the following URLs:

nextclade – ./

nextclade.vercel.app
nextclade-git-master-nextstrain.vercel.app
nextclade-nextstrain.vercel.app

Please sign in to comment.