dates: Move date logic from utils to dates
#923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To reduce clutter in utils. Coming in later commits: - update tests - update references
Codecov Report
@@ Coverage Diff @@
## master #923 +/- ##
==========================================
+ Coverage 34.59% 34.60% +0.01%
==========================================
Files 42 42
Lines 6044 6045 +1
Branches 1549 1549
==========================================
+ Hits 2091 2092 +1
Misses 3879 3879
Partials 74 74
Continue to review full report at Codecov.
|
victorlin
changed the title
utils to datesutils to dates
victorlin
changed the title
utils to datesutils to dates
This was referenced May 16, 2022
huddlej
approved these changes
May 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
This PR moves date logic from
utilsinto the newdatesmodule introduced in 2b9ba06.There is still augur/util_support/date_disambiguator.py but leaving that one for now.
Related issue(s)
N/A
Testing
Moved tests: 5644c30