dates: Use same date parsing functions for both CLI arguments and metadata #938
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Replace
get_numerical_date_from_value()
with a new function wrappingany_to_numeric()
that can return(min, max)
for non-exact dates.This ensures that the same date formats are supported across Augur to avoid issues like #747, though I wouldn't expect relative dates to be used in metadata (but the support will be there).
Tasks:
utils
todates
#923Related issue(s)
Testing
TODO