Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dates: Use same date parsing functions for both CLI arguments and metadata #938

Conversation

victorlin
Copy link
Member

@victorlin victorlin commented May 19, 2022

Description of proposed changes

Replace get_numerical_date_from_value() with a new function wrapping any_to_numeric() that can return (min, max) for non-exact dates.

This ensures that the same date formats are supported across Augur to avoid issues like #747, though I wouldn't expect relative dates to be used in metadata (but the support will be there).

Tasks:

Related issue(s)

Testing

TODO

@victorlin victorlin self-assigned this May 19, 2022
@victorlin
Copy link
Member Author

Closing in favor of #1144

@victorlin victorlin closed this Jun 28, 2024
@victorlin victorlin deleted the dates/replace-get_numerical_date_from_value branch June 28, 2024 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: In Progress
1 participant