Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate #78

Merged
merged 24 commits into from
Jun 7, 2024
Merged

Validate #78

merged 24 commits into from
Jun 7, 2024

Conversation

LouisLeNezet
Copy link
Collaborator

@LouisLeNezet LouisLeNezet commented Jun 6, 2024 •
edited
Loading

Separate the validate step from panel preparation using the posfile argument.

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/phaseimpute branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@LouisLeNezet LouisLeNezet self-assigned this Jun 6, 2024
@LouisLeNezet LouisLeNezet added the enhancement New feature or request label Jun 6, 2024
@LouisLeNezet LouisLeNezet added this to the v0.99.0 milestone Jun 6, 2024
@LouisLeNezet LouisLeNezet linked an issue Jun 6, 2024 that may be closed by this pull request
Make validate step autonomous if sites given #76
Closed
@LouisLeNezet LouisLeNezet marked this pull request as ready for review June 6, 2024 14:16
@LouisLeNezet LouisLeNezet requested a review from atrigila June 6, 2024 14:16
atrigila
atrigila approved these changes Jun 7, 2024
View reviewed changes
Copy link
Collaborator

@atrigila atrigila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, test_validate works.

@LouisLeNezet LouisLeNezet merged commit ec11c67 into nf-core:dev Jun 7, 2024
8 checks passed
@LouisLeNezet LouisLeNezet deleted the validate branch October 1, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atrigila atrigila atrigila approved these changes

Assignees

@LouisLeNezet LouisLeNezet

Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.99.0
Development

Successfully merging this pull request may close these issues.

Make validate step autonomous if sites given
2 participants
@LouisLeNezet @atrigila