-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update metadata to include all information, no longer require addon #968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #968 +/- ##
==========================================
+ Coverage 81.52% 90.31% +8.78%
==========================================
Files 27 23 -4
Lines 4049 3500 -549
==========================================
- Hits 3301 3161 -140
+ Misses 748 339 -409
Continue to review full report at Codecov.
|
* Enable nidmm build * config_addon.py is for module_version only (so far) * Remove all addon information * Update generated metadata from hapigen * Update generated files * Don't use numpy 1.16.x - broken on pypy * Don't use quotes * Update metadata based on chanes in extraction * Update generated files
The original way quit working for some reason that I was not able to track down
* Update metadata * Add config_addon * Remove unused addn information * Workaround for pypy test failing * Enable niscope * Update generated files * Update changelog with changed enum values
* Enable niswitch * Workaround for numpy with pypy * Add config_addon.py for module_version * Update metadata * Update metadata * Update generated files
* Add api version information to status documentation * Move 'last_test_version' to config_addon This will have to be manually updated as nimi-bot or other testing happens * Version from generated metadata is really the version of the API metadata, not the version tested with * Update generated files * Make key name more descriptive * Update * Update generated files
* Enable nidcpower * Add some helpful information on assert * Add config_addon * Update metadata * nimpy/pypy workaround * Update generated files
* Enable nifgen * Add config_addon for mofule_version * Update metadata * Empty out addons * Update generated files * Fix name collisions that caused values to be incorrect * Update generated files * Update CHANGELOG.md
* Fix enum.HardwareState values to match niFgen.h (#973) * Fix values for HardwareState * Update CHANGELOG.md * Fix/add incorrect or missing keys * Update generated files
…i-python into internal/metadata_updates
* Update metadata from latest build * Rename custom struct to be constistent with scope (and make it repeatable) * Update generated files * Private functions are no longer added at all * Update generated files
* Add support for ivi-dance-with-a-twist * Update generated files * Add support for ivi-dance-with-a-twist * Update metadata from latest build * Rename custom struct to be constistent with scope (and make it repeatable) * Update generated files * Enable GetAnIviDanceWithATwistString * Add test for ivi-dance-with-a-twist * Private functions are no longer added at all * Update generated files * We don't use the 'value_twist' parameter in the python api, only used for getting length * Update calls() * Update generated files
But don't do anything with it yet
* Enable nise build * Add config_addon.py - needed for module_version * Update metadata * Remove addon information * Update generated files * Update keys for recent changes * update generated files * Put modinst at the end of the build again This ensures the documentation version is based on the main drivers * Update generated files
Most of the changes in this PR have been reviewed as PRs into this branch. Exceptions:
|
marcoskirsch
approved these changes
Jun 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
False
vs'False'
List issues fixed by this Pull Request below, if any.What testing has been done?