Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update metadata to include all information, no longer require addon #968

Merged
merged 46 commits into from
Jun 3, 2019

Conversation

texasaggie97-zz
Copy link
Contributor

@texasaggie97-zz texasaggie97-zz commented Mar 26, 2019

  • This contribution adheres to CONTRIBUTING.md.
  • I've updated CHANGELOG.md if applicable.
  • I've added and updated tests applicable for this pull request

What does this Pull Request accomplish?

  • Update metadata so that main file has all information required
    • Exceptions
      • Package version - specific to GitHub and not based on underlying driver version
      • Latest driver version tested
  • Use actual booleans instead of strings that look like booleans: False vs 'False'
  • Add support for array behavior 'ivi-dance-with-a-twist'
    • Requires two calls to function similar to 'ivi-dance'
    • Instead of the size being returned in the function return, it is returned in a separate output parameter
    • nidigital will use it
  • Add nidigital metadata - but do not build it yet - See Add nidigital metadata #991

List issues fixed by this Pull Request below, if any.

What testing has been done?

  • Visual inspection
  • Unit tests

@codecov
Copy link

codecov bot commented Apr 3, 2019

Codecov Report

Merging #968 into master will increase coverage by 8.78%.
The diff coverage is 77.59%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #968      +/-   ##
==========================================
+ Coverage   81.52%   90.31%   +8.78%     
==========================================
  Files          27       23       -4     
  Lines        4049     3500     -549     
==========================================
- Hits         3301     3161     -140     
+ Misses        748      339     -409
Impacted Files Coverage Δ
generated/nifake/__init__.py 83.33% <100%> (ø) ⬆️
generated/nifake/session.py 97.56% <100%> (-0.14%) ⬇️
generated/nifake/custom_struct.py 88.46% <100%> (ø) ⬆️
generated/nimodinst/session.py 95.95% <100%> (ø) ⬆️
build/helper/metadata_filters.py 80.26% <100%> (-3.08%) ⬇️
generated/nifake/enums.py 100% <100%> (ø) ⬆️
build/helper/metadata_merge_dicts.py 89.01% <100%> (ø) ⬆️
build/helper/metadata_find.py 100% <100%> (ø) ⬆️
build/helper/codegen_helper.py 82.49% <48.97%> (-5.7%) ⬇️
build/helper/metadata_add_all.py 79.23% <62.5%> (-0.19%) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c11a66b...74bae20. Read the comment docs.

* Enable nidmm build

* config_addon.py is for module_version only (so far)

* Remove all addon information

* Update generated metadata from hapigen

* Update generated files

* Don't use numpy 1.16.x - broken on pypy

* Don't use quotes

* Update metadata based on chanes in extraction

* Update generated files
The original way quit working for some reason that I was not able to track down
* Update metadata

* Add config_addon

* Remove unused addn information

* Workaround for pypy test failing

* Enable niscope

* Update generated files

* Update changelog with changed enum values
* Enable niswitch

* Workaround for numpy with pypy

* Add config_addon.py for module_version

* Update metadata

* Update metadata

* Update generated files
* Add api version information to status documentation

* Move 'last_test_version' to config_addon

This will have to be manually updated as nimi-bot or other testing happens

* Version from generated metadata is really the version of the API metadata, not the version tested with

* Update generated files

* Make key name more descriptive

* Update

* Update generated files
* Enable nidcpower

* Add some helpful information on assert

* Add config_addon

* Update metadata

* nimpy/pypy workaround

* Update generated files
* Enable nifgen

* Add config_addon for mofule_version

* Update metadata

* Empty out addons

* Update generated files

* Fix name collisions that caused values to be incorrect

* Update generated files

* Update CHANGELOG.md
* Fix enum.HardwareState values to match niFgen.h (#973)

* Fix values for HardwareState

* Update CHANGELOG.md

* Fix/add incorrect or missing keys

* Update generated files
* Update metadata from latest build

* Rename custom struct to be constistent with scope (and make it repeatable)

* Update generated files

* Private functions are no longer added at all

* Update generated files
* Add support for ivi-dance-with-a-twist

* Update generated files

* Add support for ivi-dance-with-a-twist

* Update metadata from latest build

* Rename custom struct to be constistent with scope (and make it repeatable)

* Update generated files

* Enable GetAnIviDanceWithATwistString

* Add test for ivi-dance-with-a-twist

* Private functions are no longer added at all

* Update generated files

* We don't use the 'value_twist' parameter in the python api, only used for getting length

* Update calls()

* Update generated files
But don't do anything with it yet
* Enable nise build

* Add config_addon.py - needed for module_version

* Update metadata

* Remove addon information

* Update generated files

* Update keys for recent changes

* update generated files

* Put modinst at the end of the build again

This ensures the documentation version is based on the main drivers

* Update generated files
@texasaggie97-zz texasaggie97-zz changed the title [NOT READY TO MERGE] Update metadata to include all information, no longer require addon Update metadata to include all information, no longer require addon May 31, 2019
@texasaggie97-zz
Copy link
Contributor Author

Most of the changes in this PR have been reviewed as PRs into this branch. Exceptions:

  • Code coverage was still checking _library.py because of the name change - updated exception for "new" name
  • Add missing 'ivi-dance' unit test
  • Add 'ivi-dance-with-a-twist' unit tests - was tested by nifake unit test, but not in codegen_helper.py
  • Undid renumbering of existing cases and put all 'ivi-dance-with-a-twist' cases at the end with new numbers

@marcoskirsch marcoskirsch merged commit 7ae00fa into master Jun 3, 2019
@marcoskirsch marcoskirsch deleted the internal/metadata_updates branch June 3, 2019 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants