Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Internal/add nidmm #970

Merged
merged 9 commits into from
May 15, 2019
Merged

Internal/add nidmm #970

merged 9 commits into from
May 15, 2019

Conversation

texasaggie97-zz
Copy link
Contributor

  • This contribution adheres to CONTRIBUTING.md.
  • I've updated CHANGELOG.md if applicable.
  • I've added tests applicable for this pull request

What does this Pull Request accomplish?

  • Adds newly generated metadata for nidmm

List issues fixed by this Pull Request below, if any.

What testing has been done?

@codecov
Copy link

codecov bot commented Apr 10, 2019 •
edited
Loading

Codecov Report

Merging #970 into internal/metadata_updates will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@                    Coverage Diff                     @@
##           internal/metadata_updates     #970   +/-   ##
==========================================================
  Coverage                      81.53%   81.53%           
==========================================================
  Files                             27       27           
  Lines                           4050     4050           
==========================================================
  Hits                            3302     3302           
  Misses                           748      748

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2167adf...ea9036f. Read the comment docs.

@marcoskirsch marcoskirsch merged commit f6a7677 into internal/metadata_updates May 15, 2019
marcoskirsch pushed a commit that referenced this pull request Jun 3, 2019
@texasaggie97-zz @marcoskirsch
Update metadata to include all information, no longer require addon (#…
7ae00fa 
…968)

* flake8 has gotten stricter

* Additional infomarion when error or abnormal condition

* Need to merge config as well

* Use actual booleans instead of a string that looks like a boolean

* Since we now merge config, not all top level items are a dictionary

* Update generated files

* Only build nifake for now. Others will be added over time

* Update metadata

* Make naming consistent with other drivers

* Enable ModInst

* Disable testing drivers we are building yet

* Add config_addon

* Update metadata

* Handle minor change in metadata format (now booleans instead of strings)

* Update generated files

* Internal/add nidmm (#970)

* Enable nidmm build

* config_addon.py is for module_version only (so far)

* Remove all addon information

* Update generated metadata from hapigen

* Update generated files

* Don't use numpy 1.16.x - broken on pypy

* Don't use quotes

* Update metadata based on chanes in extraction

* Update generated files

* See if this fixes pypy3 build/test breakage

* Allow pypy3 to fail for now

* Simple change to force rebuild

* Try to fix the build

* Change how filtering configuration dictionary is declared

The original way quit working for some reason that I was not able to track down

* Try to fix error on travis ci

* Need enum34 for Python 2.7

* Update niscope metadata to new extraction type (#980)

* Update metadata

* Add config_addon

* Remove unused addn information

* Workaround for pypy test failing

* Enable niscope

* Update generated files

* Update changelog with changed enum values

* Internal/niswitch (#971)

* Enable niswitch

* Workaround for numpy with pypy

* Add config_addon.py for module_version

* Update metadata

* Update metadata

* Update generated files

* Differentiate between tested with version and api version (#983)

* Add api version information to status documentation

* Move 'last_test_version' to config_addon

This will have to be manually updated as nimi-bot or other testing happens

* Version from generated metadata is really the version of the API metadata, not the version tested with

* Update generated files

* Make key name more descriptive

* Update

* Update generated files

* Internal/nidcpower (#982)

* Enable nidcpower

* Add some helpful information on assert

* Add config_addon

* Update metadata

* nimpy/pypy workaround

* Update generated files

* Internal/add fgen (#972)

* Enable nifgen

* Add config_addon for mofule_version

* Update metadata

* Empty out addons

* Update generated files

* Fix name collisions that caused values to be incorrect

* Update generated files

* Update CHANGELOG.md

* Internal/fix build (#987)

* Fix enum.HardwareState values to match niFgen.h (#973)

* Fix values for HardwareState

* Update CHANGELOG.md

* Fix/add incorrect or missing keys

* Update generated files

* Update nifake metadata (#988)

* Update metadata from latest build

* Rename custom struct to be constistent with scope (and make it repeatable)

* Update generated files

* Private functions are no longer added at all

* Update generated files

* Add behavior type ivi-dance-with-a-twist (#989)

* Add support for ivi-dance-with-a-twist

* Update generated files

* Add support for ivi-dance-with-a-twist

* Update metadata from latest build

* Rename custom struct to be constistent with scope (and make it repeatable)

* Update generated files

* Enable GetAnIviDanceWithATwistString

* Add test for ivi-dance-with-a-twist

* Private functions are no longer added at all

* Update generated files

* We don't use the 'value_twist' parameter in the python api, only used for getting length

* Update calls()

* Update generated files

* Add nidigital metadata (#991)

But don't do anything with it yet

* Add SwitchExecutive (#992)

* Enable nise build

* Add config_addon.py - needed for module_version

* Update metadata

* Remove addon information

* Update generated files

* Update keys for recent changes

* update generated files

* Put modinst at the end of the build again

This ensures the documentation version is based on the main drivers

* Update generated files

* Update order and add comment why

* Clean up addon files

* Library file name changed

* Add missing comment with missing case

* Add some missing unit tests

* Update generated files

* Don't renumber existing cases

* Fix incorrect case - comment was correct

* Add some missing test cases

* Update generated files
texasaggie97-zz added a commit that referenced this pull request Jun 6, 2019
@texasaggie97-zz
Add simple nidigital API - no Pythonic niceties (#994)
0c1e1c4 
* flake8 has gotten stricter
* Additional infomarion when error or abnormal condition
* Need to merge config as well
* Use actual booleans instead of a string that looks like a boolean
* Since we now merge config, not all top level items are a dictionary
* Update generated files
* Only build nifake for now. Others will be added over time
* Update metadata
* Make naming consistent with other drivers
* Enable ModInst
* Disable testing drivers we are building yet
* Add config_addon
* Update metadata
* Handle minor change in metadata format (now booleans instead of strings)
* Update generated files
* Add nidigital metadata
* Enable nidigital
* Add simple example and system_test
* nidigital doesn't have documentation but we need at least an empy dictionary
* Move import datetime into the snippet that uses it
* Simple usage file
* Add support for ivi-dance-with-a-twist
* When filtering, either works
* When finding associated parameter, take a key to look at: 'value' or ;value-twist'
* Renumber declaration types
* Add/update generated files
* Internal/add nidmm (#970)
* Enable nidmm build
* config_addon.py is for module_version only (so far)
* Remove all addon information
* Update generated metadata from hapigen
* Update generated files
* Don't use numpy 1.16.x - broken on pypy
* Don't use quotes
* Update metadata based on chanes in extraction
* Update generated files
* See if this fixes pypy3 build/test breakage
* Allow pypy3 to fail for now
* Simple change to force rebuild
* Try to fix the build
* Change how filtering configuration dictionary is declared
   The original way quit working for some reason that I was not able to track down
* Try to fix error on travis ci
* Need enum34 for Python 2.7
* Update niscope metadata to new extraction type (#980)
* Update metadata
* Add config_addon
* Remove unused addn information
* Workaround for pypy test failing
* Enable niscope
* Update generated files
* Update changelog with changed enum values
* Move import datetime back into session.py.mako but skip flake8 error
* Update generated files
* Update changelog
* Internal/niswitch (#971)
* Enable niswitch
* Workaround for numpy with pypy
* Add config_addon.py for module_version
* Update metadata
* Update metadata
* Update generated files
* Differentiate between tested with version and api version (#983)
* Add api version information to status documentation
* Move 'last_test_version' to config_addon
   This will have to be manually updated as nimi-bot or other testing happens
* Version from generated metadata is really the version of the API metadata, not the version tested with
* Update generated files
* Make key name more descriptive
* Update
* Update generated files
* Internal/nidcpower (#982)
* Enable nidcpower
* Add some helpful information on assert
* Add config_addon
* Update metadata
* nimpy/pypy workaround
* Update generated files
* Internal/add fgen (#972)
* Enable nifgen
* Add config_addon for mofule_version
* Update metadata
* Empty out addons
* Update generated files
* Fix name collisions that caused values to be incorrect
* Update generated files
* Update CHANGELOG.md
* Update changelog per review comments
* Clean up incorrect comments per review
* Fix comment per review
* Update and expand on docstring per review
* Remove reference to nidcpower per review
* Add TODO per review
* Internal/fix build (#987)
* Fix enum.HardwareState values to match niFgen.h (#973)
* Fix values for HardwareState
* Update CHANGELOG.md
* Fix/add incorrect or missing keys
* Update generated files
* Update nifake metadata (#988)
* Update metadata from latest build
* Rename custom struct to be constistent with scope (and make it repeatable)
* Update generated files
* Private functions are no longer added at all
* Update generated files
* Add behavior type ivi-dance-with-a-twist (#989)
* Add support for ivi-dance-with-a-twist
* Update generated files
* Add support for ivi-dance-with-a-twist
* Update metadata from latest build
* Rename custom struct to be constistent with scope (and make it repeatable)
* Update generated files
* Enable GetAnIviDanceWithATwistString
* Add test for ivi-dance-with-a-twist
* Private functions are no longer added at all
* Update generated files
* We don't use the 'value_twist' parameter in the python api, only used for getting length
* Update calls()
* Update generated files
* Rename and remove functionality
* Update generated files
* Update generated files
* Add nidigital metadata (#991)
   But don't do anything with it yet
* Add SwitchExecutive (#992)
* Enable nise build
* Add config_addon.py - needed for module_version
* Update metadata
* Remove addon information
* Update generated files
* Update keys for recent changes
* update generated files
* Put modinst at the end of the build again
   This ensures the documentation version is based on the main drivers
* Update generated files
* Add missing key
* Fix key name
* Update generated files
* Update order and add comment
* Fix name
* Update order and add comment why
* Clean up addon files
* Library file name changed
* Add missing comment with missing case
* Add some missing unit tests
* Update generated files
* Don't renumber existing cases
* Fix incorrect case - comment was correct
* Add some missing test cases
* Update generated files
* Update generated files
@texasaggie97-zz texasaggie97-zz deleted the internal/add_nidmm branch June 11, 2019 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcoskirsch marcoskirsch marcoskirsch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@texasaggie97-zz @marcoskirsch