Add simple nidigital API - no Pythonic niceties #994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* When filtering, either works * When finding associated parameter, take a key to look at: 'value' or ;value-twist' * Renumber declaration types
* Enable nidmm build * config_addon.py is for module_version only (so far) * Remove all addon information * Update generated metadata from hapigen * Update generated files * Don't use numpy 1.16.x - broken on pypy * Don't use quotes * Update metadata based on chanes in extraction * Update generated files
The original way quit working for some reason that I was not able to track down
But don't do anything with it yet
* Enable nise build * Add config_addon.py - needed for module_version * Update metadata * Remove addon information * Update generated files * Update keys for recent changes * update generated files * Put modinst at the end of the build again This ensures the documentation version is based on the main drivers * Update generated files
Codecov Report
@@ Coverage Diff @@
## master #994 +/- ##
=========================================
Coverage ? 91.33%
=========================================
Files ? 23
Lines ? 3542
Branches ? 0
=========================================
Hits ? 3235
Misses ? 307
Partials ? 0
Continue to review full report at Codecov.
|
marcoskirsch
approved these changes
Jun 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added tests applicable for this pull requestWhat does this Pull Request accomplish?
List issues fixed by this Pull Request below, if any.What testing has been done?