resolve fetchgit issue with nix 2.4 #115
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds `allRefs = true;` to the invocation of fetchGit as opposed to repassing the commit hash as the ref, which fails with nix version >=2.4 Fixes nix-community#91
|
I was just bit by this as well while trying to contribute to the repository and update some tests. The commit fixes the issue for me and it would be cool to merge this sooner rather than later ⭐ |
|
Thanks for the PR. I'm finally able to look at this. |
andir
reviewed
Nov 13, 2021
| @@ -67,7 +67,8 @@ rec { | |||
| } else | |||
| builtins.fetchGit { | |||
| url = "https://github.com/${org}/${repo}"; | |||
| inherit rev ref; | |||
| inherit rev; | |||
| allRefs = true; | |||
There was a problem hiding this comment.
If this is all it takes this sounds good. Just have to make sure it doesn't break on older versions of nix (2.3)
|
Thank you for the PR. I've integrated your work in #124 which added more backwards compat and not just Nix 2.4 support. |
|
Amazing. Thanks for all your work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
allRefs = true;to the invocation of fetchGitas opposed to repassing the commit hash as the ref, which
fails with nix version >=2.4
Fixes #91