Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nix2.4 support #124

Merged
merged 4 commits into from
Nov 13, 2021
Merged

Nix2.4 support #124

merged 4 commits into from
Nov 13, 2021

Conversation

andir
Copy link
Collaborator

@andir andir commented Nov 13, 2021

This fixes various little bits within the repo to support Nix 2.4. to a degree where our CI doesn't fail anymore.

As part of this I also changed the CI workflow to always run the test.sh against the latest stable nix release and Nix 2.3.

andir and others added 4 commits November 13, 2021 21:46
Nix 2.4 introduced a breakage/bug that requies anything that pretends to
be nixpkgs to accept arbitrary arguments. We just accept and ignore them
for now.

Verified

This commit was signed with the committer’s verified signature.
Adds `allRefs = true;` to the invocation of fetchGit
as opposed to repassing the commit hash as the ref, which
fails with nix version >=2.4
Fixes #91

Verified

This commit was signed with the committer’s verified signature.
@andir andir requested a review from gilligan November 13, 2021 21:05
Copy link
Collaborator

@gilligan gilligan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sigh.

@gilligan gilligan merged commit 347a6d6 into master Nov 13, 2021
@gilligan gilligan deleted the nix2.4-support branch November 13, 2021 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants