-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to zig 0.13.0 #3
base: master
Are you sure you want to change the base?
Conversation
Updated `field.field_type` to `field.type` for better consistency with Zig's type system. Replaced `@ptrCast` with `@as` for pointer conversions and added `const` qualifiers where applicable. Modified test cases to reflect these changes and ensure correctness. This refactoring aligns the code with current current stable (0.13.0) version without altering functionality.
Thank you for the PR! I just want to caution you about this library (I should put this in the README as well): I found that it doesn't work will with the zig standard library data structures which sometimes have:
For the use-case I wrote sealed_and_compact, I instead ended up writing a custom serializer/deserializer that accounts for specific implementation details of standard library functions. |
Hi @nsmryan! I've addressed some of those problems with slices in my other PR #4.
It is, and in fact, I looked at two or three other serialisation libraries and even fixed one to learn that recursive structures cannot be resolved due to its "comptime" nature. It seems ========= Optional PR no. 1Once you'll be able to go through those two PR's I'd be happy to add a custom test runner so you'll be able to see the results like:
Optional PR no. 2I could also add a Github actions config with a badge in README. ========= You can check my Fork for both options. |
This PR mainly focuses on getting the library build and tests passing on version 0.13.0.
The only addition is making the library possible to
fetch
as a dependency like: