fix seal and unseal of nested and recursive structures, strings (char slices) #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated `field.field_type` to `field.type` for better consistency with Zig's type system. Replaced `@ptrCast` with `@as` for pointer conversions and added `const` qualifiers where applicable. Modified test cases to reflect these changes and ensure correctness. This refactoring aligns the code with current current stable (0.13.0) version without altering functionality.
Update to zig 0 13 0
… slices) This commit will enable serializing and deserializing nested structures by fixing how variant_ptr gets initialized. I also added new test cases to ensure all my use cases would be covered by this library: - compact union with string field - seal and unseal with buffer: - union with string field - structure with enum field - structure with an optional slice of structures - recursive structure - complex recursive union And renamed `value` to `value_ptr` across the `repair` function and updated related references to imporve reasoning about the value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit will enable serializing and deserializing nested structures by fixing how variant_ptr gets initialized.
I also added new test cases to ensure all my use cases would be covered by this library:
For all seal and unseal new tests I used
std.testing.allocatorto detect any memory leaks.And renamed
valuetovalue_ptracross therepairfunction and updated related references to improve reasoning about the value.