fix: various clarifications #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* loosen shutdown requirements to support things like go ctx * clarify how to handle init/shutdown of providers bound to multiple names * clarify init function should terminate before provider used Signed-off-by: Todd Baert <[email protected]>
toddbaert
requested review from
weyert,
kinyoklion,
lopitz,
Kavindu-Dodan,
lukas-reining and
beeme1mr
beeme1mr
approved these changes
May 31, 2023
kinyoklion
reviewed
May 31, 2023
Signed-off-by: Todd Baert <[email protected]>
kinyoklion
approved these changes
May 31, 2023
lopitz
reviewed
May 31, 2023
Kavindu-Dodan
approved these changes
May 31, 2023
benjiro
approved these changes
Jun 1, 2023
Signed-off-by: Todd Baert <[email protected]>
lukas-reining
approved these changes
Jun 2, 2023
justinabrahms
approved these changes
Jun 2, 2023
|
The spec shows that the initialization accepts a global context as a parameter. However the java sdk provider interface has the initialization API without any parameters. Is there any discussion regarding that? |
I think this is an oversight. I will open an issue in the Java SDK (we haven't released yet, so no issue). Great find. |
This was referenced Jun 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
API.shutdown()required in Go? #189clarify init function should terminate before provider used feat: add initialize and shutdown behavior java-sdk#456 (comment)cc @open-feature/technical-steering-committee @lopitz @lukas-reining @kinyoklion @Kavindu-Dodan
Definitely let me know anyone thinks something is missing or could be improved here.