fix: only shutdown providers that are not attached to any client #444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lukas Reining <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #444 +/- ##
=======================================
Coverage 99.47% 99.47%
=======================================
Files 25 25
Lines 2468 2469 +1
Branches 236 236
=======================================
+ Hits 2455 2456 +1
Misses 13 13
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Co-authored-by: Michael Beemer <[email protected]> Signed-off-by: Lukas Reining <[email protected]>
|
@toddbaert are you waiting for the spec change to be merged? If so, could you link that PR here? |
Ya, I'm waiting for open-feature/spec#193 just to avoid any thrashing. |
toddbaert
approved these changes
Jun 2, 2023
There was a problem hiding this comment.
This LGTM. I will wait to merge once open-feature/spec#193 is merged.
This was referenced Jun 2, 2023
beeme1mr
pushed a commit
that referenced
this pull request
Jun 6, 2023
🤖 I have created a release *beep* *boop* --- ## [0.0.4](shared-v0.0.3...shared-v0.0.4) (2023-06-06) ### Features * add init/shutdown and events ([#436](#436)) ([5d55ea1](5d55ea1)) * add named client support ([#429](#429)) ([310c6ac](310c6ac)) * add support for flag metadata ([#426](#426)) ([029ec26](029ec26)) ### Bug Fixes * only shutdown providers that are not attached to any client ([#444](#444)) ([7e469c4](7e469c4)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
beeme1mr
pushed a commit
that referenced
this pull request
Jun 6, 2023
🤖 I have created a release *beep* *boop* --- ## [0.3.3-experimental](web-sdk-v0.3.2-experimental...web-sdk-v0.3.3-experimental) (2023-06-06) ### Features * add init/shutdown and events ([#436](#436)) ([5d55ea1](5d55ea1)) * add named client support ([#429](#429)) ([310c6ac](310c6ac)) * add support for flag metadata ([#426](#426)) ([029ec26](029ec26)) ### Bug Fixes * bundlers wrongly resolving server/client modules ([#445](#445)) ([6acddd5](6acddd5)) * only shutdown providers that are not attached to any client ([#444](#444)) ([7e469c4](7e469c4)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
beeme1mr
added a commit
that referenced
this pull request
Jun 6, 2023
🤖 I have created a release *beep* *boop* --- ## [1.3.0](js-sdk-v1.2.0...js-sdk-v1.3.0) (2023-06-06) ### Features * add init/shutdown and events ([#436](#436)) ([5d55ea1](5d55ea1)) * add named client support ([#429](#429)) ([310c6ac](310c6ac)) * add support for flag metadata ([#426](#426)) ([029ec26](029ec26)) ### Bug Fixes * bundlers wrongly resolving server/client modules ([#445](#445)) ([6acddd5](6acddd5)) * only shutdown providers that are not attached to any client ([#444](#444)) ([7e469c4](7e469c4)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Signed-off-by: Michael Beemer <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Michael Beemer <[email protected]>
This was referenced Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Providers that are bound to several named clients are closed if another provider is set for one of these clients.
This PR only closes providers if they are not used by any client.
Related Issues
Fixes #443
Notes
Follow-up Tasks
How to test
Added tests for server and client.