-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: bundlers wrongly resolving server/client modules #445
Conversation
Signed-off-by: Todd Baert <[email protected]>
@moredip I'm confident enough that this is the root cause of your issue that I think we should just commit it. I've seen the same behavior myself, but it's very tough to reproduce consistently. Regardless, there's no reason I can think of that these 2 symbols should be the same. |
Codecov Report
@@ Coverage Diff @@
## main #445 +/- ##
==========================================
- Coverage 99.47% 99.47% -0.01%
==========================================
Files 25 25
Lines 2469 2468 -1
Branches 236 236
==========================================
- Hits 2456 2455 -1
Misses 13 13
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it make sense to use a different symbol for client and server. I'm just wondering if we should call it client and server instead of web-sdk
and js-sdk
. Client/server is what we went with on the main readme.
I had the same thought but went with the actual artifact name because I thought that would make it very clear in debugging. |
🤖 I have created a release *beep* *boop* --- ## [0.3.3-experimental](web-sdk-v0.3.2-experimental...web-sdk-v0.3.3-experimental) (2023-06-06) ### Features * add init/shutdown and events ([#436](#436)) ([5d55ea1](5d55ea1)) * add named client support ([#429](#429)) ([310c6ac](310c6ac)) * add support for flag metadata ([#426](#426)) ([029ec26](029ec26)) ### Bug Fixes * bundlers wrongly resolving server/client modules ([#445](#445)) ([6acddd5](6acddd5)) * only shutdown providers that are not attached to any client ([#444](#444)) ([7e469c4](7e469c4)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
🤖 I have created a release *beep* *boop* --- ## [1.3.0](js-sdk-v1.2.0...js-sdk-v1.3.0) (2023-06-06) ### Features * add init/shutdown and events ([#436](#436)) ([5d55ea1](5d55ea1)) * add named client support ([#429](#429)) ([310c6ac](310c6ac)) * add support for flag metadata ([#426](#426)) ([029ec26](029ec26)) ### Bug Fixes * bundlers wrongly resolving server/client modules ([#445](#445)) ([6acddd5](6acddd5)) * only shutdown providers that are not attached to any client ([#444](#444)) ([7e469c4](7e469c4)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Signed-off-by: Michael Beemer <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Michael Beemer <[email protected]>
Fixes an issue that can cause bundlers in repos with both the web-sdk and js-sdk to incorrectly resolve and bundle module components because both modules use the same global symbols for the API.