Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add named client support #429

Merged
merged 11 commits into from
May 24, 2023
Merged

feat: add named client support #429

merged 11 commits into from
May 24, 2023

Conversation

lukas-reining
Copy link
Member

This PR

Implements named client support. #428

Had to also add the provider status that is defined in the provider lifecycle and used for events.

Related Issues

Fixes #428

Notes

This feature is part of the recently released v0.6.0 of the OpenFeature spec.

Follow-up Tasks

I would after this continue with the events and init/shutdown to round everything up.

How to test

Tests are included for both client and server.

@lukas-reining lukas-reining requested a review from a team May 23, 2023 14:02
@lukas-reining lukas-reining changed the title Implement named client support feat: Implement named client support May 23, 2023
@lukas-reining lukas-reining changed the title feat: Implement named client support feat: implement named client support May 23, 2023
@codecov
Copy link

codecov bot commented May 23, 2023 •
edited
Loading

Codecov Report

Merging #429 (3326883) into main (029ec26) will increase coverage by 99.44%.
The diff coverage is 98.69%.

❗ Current head 3326883 differs from pull request most recent head cd742d9. Consider uploading reports for the commit cd742d9 to get more accurate results

@@            Coverage Diff            @@
##           main     #429       +/-   ##
=========================================
+ Coverage      0   99.44%   +99.44%     
=========================================
  Files         0       24       +24     
  Lines         0     2331     +2331     
  Branches      0      211      +211     
=========================================
+ Hits          0     2318     +2318     
- Misses        0       13       +13
Impacted Files Coverage Δ
packages/client/src/open-feature.ts 97.10% <97.08%> (ø)
packages/server/src/open-feature.ts 98.87% <97.80%> (ø)
packages/client/src/client.ts 98.93% <100.00%> (ø)
packages/client/src/no-op-provider.ts 100.00% <100.00%> (ø)
packages/client/src/types.ts 100.00% <100.00%> (ø)
packages/server/src/client.ts 100.00% <100.00%> (ø)
packages/server/src/types.ts 100.00% <100.00%> (ø)
packages/shared/src/type-guards.ts 100.00% <100.00%> (ø)
packages/shared/src/types.ts 100.00% <100.00%> (ø)

... and 15 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@lukas-reining lukas-reining force-pushed the feat/428-named-client-support branch from 55bdca9 to 592d294 Compare May 23, 2023 15:23
beeme1mr
beeme1mr reviewed May 23, 2023
View reviewed changes
Copy link
Member

@beeme1mr beeme1mr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left some feedback, but it looks good to me.

@lukas-reining lukas-reining requested a review from beeme1mr May 23, 2023 18:01
@toddbaert
Copy link
Member

I left a few minor comments, but this looks very good to me. Take a look at my comments but I think I can approve this soon.

@lukas-reining lukas-reining requested a review from toddbaert May 24, 2023 14:23
@toddbaert toddbaert requested review from toddbaert and RealAnna May 24, 2023 15:03
@toddbaert toddbaert changed the title feat: implement named client support feat: add named client support May 24, 2023
beeme1mr
beeme1mr approved these changes May 24, 2023
View reviewed changes
Copy link
Member

@beeme1mr beeme1mr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, thanks! There are a few minor lint warnings that may be worth addressing before you merge

@lukas-reining
Copy link
Member Author

Approved, thanks! There are a few minor lint warnings that may be worth addressing before you merge

Nice thanks @beeme1mr!
I fixed the linter warnings too now.
I am not allowed to merge the branch, so how do we do it @beeme1mr @toddbaert?

lukas-reining and others added 5 commits May 24, 2023 16:04
@lukas-reining @toddbaert
Fix naming in test
6a55912 
Co-authored-by: Todd Baert <[email protected]>
Signed-off-by: Lukas Reining <[email protected]>
@lukas-reining @toddbaert
Improve comment on flagd waiting hack in e2e tests
85a7adf 
Co-authored-by: Todd Baert <[email protected]>
Signed-off-by: Lukas Reining <[email protected]>
@lukas-reining @toddbaert
Change setProvider documentation and fix wording
93c5b0e 
Signed-off-by: Lukas Reining <[email protected]>
@lukas-reining @toddbaert
Change setProvider documentation and fix wording
9da05a4 
Signed-off-by: Lukas Reining <[email protected]>
@lukas-reining @toddbaert
Fix linter warnings
cd742d9 
Signed-off-by: Lukas Reining <[email protected]>
@toddbaert toddbaert force-pushed the feat/428-named-client-support branch from 3326883 to cd742d9 Compare May 24, 2023 20:04
@toddbaert toddbaert merged commit 310c6ac into open-feature:main May 24, 2023
@toddbaert
Copy link
Member

Approved, thanks! There are a few minor lint warnings that may be worth addressing before you merge

Nice thanks @beeme1mr! I fixed the linter warnings too now. I am not allowed to merge the branch, so how do we do it @beeme1mr @toddbaert?

rebased and merged

This was referenced May 24, 2023
Merged
Merged
Merged
@lukas-reining lukas-reining mentioned this pull request May 24, 2023
Closed
@toddbaert toddbaert mentioned this pull request May 25, 2023
Merged
beeme1mr pushed a commit that referenced this pull request Jun 6, 2023
@github-actions
chore(main): release shared 0.0.4 (#431)
f5de2d5 
🤖 I have created a release *beep* *boop*
---


##
[0.0.4](shared-v0.0.3...shared-v0.0.4)
(2023-06-06)


### Features

* add init/shutdown and events
([#436](#436))
([5d55ea1](5d55ea1))
* add named client support
([#429](#429))
([310c6ac](310c6ac))
* add support for flag metadata
([#426](#426))
([029ec26](029ec26))


### Bug Fixes

* only shutdown providers that are not attached to any client
([#444](#444))
([7e469c4](7e469c4))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
beeme1mr pushed a commit that referenced this pull request Jun 6, 2023
@github-actions
chore(main): release web-sdk 0.3.3-experimental (#432)
f2887fc 
🤖 I have created a release *beep* *boop*
---


##
[0.3.3-experimental](web-sdk-v0.3.2-experimental...web-sdk-v0.3.3-experimental)
(2023-06-06)


### Features

* add init/shutdown and events
([#436](#436))
([5d55ea1](5d55ea1))
* add named client support
([#429](#429))
([310c6ac](310c6ac))
* add support for flag metadata
([#426](#426))
([029ec26](029ec26))


### Bug Fixes

* bundlers wrongly resolving server/client modules
([#445](#445))
([6acddd5](6acddd5))
* only shutdown providers that are not attached to any client
([#444](#444))
([7e469c4](7e469c4))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
beeme1mr added a commit that referenced this pull request Jun 6, 2023
@github-actions @beeme1mr
chore(main): release js-sdk 1.3.0 (#433)
2a357c7 
🤖 I have created a release *beep* *boop*
---


##
[1.3.0](js-sdk-v1.2.0...js-sdk-v1.3.0)
(2023-06-06)


### Features

* add init/shutdown and events
([#436](#436))
([5d55ea1](5d55ea1))
* add named client support
([#429](#429))
([310c6ac](310c6ac))
* add support for flag metadata
([#426](#426))
([029ec26](029ec26))


### Bug Fixes

* bundlers wrongly resolving server/client modules
([#445](#445))
([6acddd5](6acddd5))
* only shutdown providers that are not attached to any client
([#444](#444))
([7e469c4](7e469c4))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Signed-off-by: Michael Beemer <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Michael Beemer <[email protected]>
This was referenced Jul 26, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beeme1mr beeme1mr beeme1mr approved these changes

@toddbaert toddbaert toddbaert approved these changes

@RealAnna RealAnna Awaiting requested review from RealAnna

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

implement named client support: open-feature/spec@4cf8229
3 participants
@lukas-reining @toddbaert @beeme1mr