config: Simplify the paragraph contrasting diffIDs with layer digests #515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@stevvooe, you may want to close this PR and reopen your own with the same change (or whatever makes sense to you). |
stevvooe
reviewed
Jan 19, 2017
| @@ -28,7 +28,7 @@ Changing it means creating a new derived image, instead of changing the existing | |||
| A layer DiffID is a SHA256 digest over the layer's uncompressed tar archive and serialized in the descriptor digest format, e.g., `sha256:a9561eb1b190625c9adb5a9513e72c4dedafc1cb2d4c5236c9a6957ec7dfd5a9`. | |||
| Layers must be packed and unpacked reproducibly to avoid changing the layer DiffID, for example by using tar-split to save the tar headers. | |||
|
|
|||
| NOTE: the DiffID is different than the layer digest because it is taken over the uncompressed gzipped layer for `application/vnd.oci.image.layer.v1.tar+gzip` types. | |||
| Do not confuse DiffIDs with [layer digests](manifest.md#image-manifest-property-descriptions), often referenced in the manifest, which allow digests over compressed or uncompressed content. | |||
There was a problem hiding this comment.
One change: leave as a NOTE.
|
LGTM after adding NOTE. |
Trevor and I couldn't agree on more detailed wording [1], and this paragraph was never normative anyway. [1]: opencontainers#388 (comment) Signed-off-by: Stephen J Day <[email protected]> Signed-off-by: W. Trevor King <[email protected]>
wking
force-pushed
the
simplify-diffID-vs-layer-digest
branch
from
4bd5ba7 to
9286846
Compare
|
LGTM |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@stevvooe and I couldn't agree on more detailed wording, and this paragraph was never normative anyway.
Spun off from #388 starting here. The new wording does not mention media types at all, so there's no reason to tangle it up with the rest of #388.
CC @stevvooe.