Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

layer is compressed tar format #518

Closed
wants to merge 1 commit into from
Closed

layer is compressed tar format #518

wants to merge 1 commit into from

Conversation

xiekeyang
Copy link
Contributor

Signed-off-by: xiekeyang [email protected]

wking
wking reviewed Jan 23, 2017
View reviewed changes
config.md
@@ -12,7 +12,7 @@ This specification uses the following terms:
### [Layer](layer.md)

Image filesystems are composed of *layers*.
Each layer represents a set of filesystem changes in a tar-based [layer format](layer.md), recording files to be added, changed, or deleted relative to its parent layer.
Each layer represents a set of filesystem changes in a compressed tar-based [layer format](layer.md), recording files to be added, changed, or deleted relative to its parent layer.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is currently covered here, and will no longer be true if/when #388 lands. In any event, compression seems like a property of the later media type, and not a fundamental property of “being a layer”.

@xiekeyang
Copy link
Contributor Author

@wking You are right, this should be closed.

@xiekeyang xiekeyang closed this Jan 23, 2017
@xiekeyang
Copy link
Contributor Author

@wking I have a question.

compression seems like a property of the later media type, and not a fundamental property of “being a layer”.

Then, if this comment are a little conflict to #515, as Do not confuse DiffIDs with layer digests, often referenced in the manifest, which are digests over compressed content.?

If above words in #515 should be modified?

@xiekeyang xiekeyang deleted the layer branch January 23, 2017 02:08
@wking
Copy link
Contributor

wking commented Jan 23, 2017

If above words in #515 should be modified?

Those words are fine now. I'm restoring @stevvooe's "uncompressed" wording in #388.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wking wking wking left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xiekeyang @wking