Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync2 #289

Merged
merged 18 commits into from
Apr 8, 2024
Merged

Sync2 #289

merged 18 commits into from
Apr 8, 2024

Conversation

spolti
Copy link
Member

@spolti spolti commented Apr 5, 2024

No description provided.

spolti and others added 17 commits March 23, 2024 20:31
chore:	fixes the GH [Alert](https://github.com/kserve/kserve/security/code-scanning/12080).
	filepath.Clean sanitizes the directory path and remove any unnecessary components (such as . and ..)

Signed-off-by: Spolti <[email protected]>
Due to changes in kserve@39b8a67 which added `reinvocationPolicy: IfNeeded` to the WebHook configuration, the injection called can (and will be) called multiple times, and needs to be idempotent (which is a good thing anyway).

This commit fixes the array field handling and adding volumes, volumemounts and containers only if they not already had been added.

Fixes kserve#3506

Signed-off-by: Roland Huß <[email protected]>
…e#3481)

Remove redundant helm chart affinity

labels: 
- app.kubernetes.io/managed-by 
- app.kubernetes.io/instance
- app.kubernetes.io/name: 

with value modelmesh-controller cause affinity to non existent helm chart

Signed-off-by: Ondrej Trojan <[email protected]>
update codeQL to v3

chore:	Update CodeQL to V3 to get rid of this warning:
	`Warning: CodeQL Action v2 will be deprecated on December 5th, 2024`
	Plus, attenpt to fix the Snyk Container scan failures due errors when trying to
	upload the SERIF file:
	`Processing sarif files: ["application/storage-initializer/docker.snyk.sarif"]
	  Uploading results
	  Successfully uploaded results
	Waiting for processing to finish
	Error: Code Scanning could not process the submitted SARIF file:
	could not convert rules: invalid security severity value, is not a number: null
	ConfigurationError: Code Scanning could not process the submitted SARIF file:
	could not convert rules: invalid security severity value, is not a number: null
	    at run (/home/runner/work/_actions/github/codeql-action/v2/lib/upload-sarif-action.js:65:15)`

Signed-off-by: Spolti <[email protected]>
* switch e2e test inference graph to raw mode

Signed-off-by: Andrews Arokiam <[email protected]>

* download xgb server image

Signed-off-by: Andrews Arokiam <[email protected]>

---------

Signed-off-by: Andrews Arokiam <[email protected]>
Pad left for decode-only architecture models.

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>
* CVE-2024-24762 - update fastapi to 0.109.1

chore:	Fix [CVE-2024-24762](https://www.cve.org/CVERecord?id=CVE-2024-24762) - fastapi Regular Expression Denial of Service (ReDoS)
	Plus, update Ray to 2.10 to allow updating fastapi. On previous versions of Ray
	the fastapi version was pinned, which was preventing the fastapi version update.

use the new handle api:

From Ray Serve docs:
Ray 2.7 introduces a new {mod}`DeploymentHandle <ray.serve.handle.DeploymentHandle>` API that will replace the existing `RayServeHandle` and `RayServeSyncHandle` APIs.

Signed-off-by: Spolti <[email protected]>

* add link to about the RayServeHandle deprecation

Signed-off-by: Spolti <[email protected]>

---------

Signed-off-by: Spolti <[email protected]>
* wip

Signed-off-by: Yuan Tang <[email protected]>

* comment out

Signed-off-by: Yuan Tang <[email protected]>

* fix wf

Signed-off-by: Yuan Tang <[email protected]>

* helm test

Signed-off-by: Yuan Tang <[email protected]>

* remove mlserver relate tests

Signed-off-by: Yuan Tang <[email protected]>

* fix lint

Signed-off-by: Yuan Tang <[email protected]>

* sklearnserver runtime

Signed-off-by: Yuan Tang <[email protected]>

* Fix test

Signed-off-by: Yuan Tang <[email protected]>

* fix

Signed-off-by: Yuan Tang <[email protected]>

* disable check

Signed-off-by: Yuan Tang <[email protected]>

* reunused imports

Signed-off-by: Yuan Tang <[email protected]>

* Add back mlserver

Signed-off-by: Yuan Tang <[email protected]>

* pre-commit fix

Signed-off-by: Yuan Tang <[email protected]>

* update storage url

Signed-off-by: Yuan Tang <[email protected]>

* fix build

Signed-off-by: Yuan Tang <[email protected]>

* fix codegen

Signed-off-by: Yuan Tang <[email protected]>

* revert uri

Signed-off-by: Yuan Tang <[email protected]>

* int_contents

Signed-off-by: Yuan Tang <[email protected]>

* Remove unused script

Signed-off-by: Yuan Tang <[email protected]>

* remove dockerfile

Signed-off-by: Yuan Tang <[email protected]>

* Empty-Commit

Signed-off-by: Yuan Tang <[email protected]>

* Empty-Commit

Signed-off-by: Yuan Tang <[email protected]>

* Empty-Commit

Signed-off-by: Yuan Tang <[email protected]>

---------

Signed-off-by: Yuan Tang <[email protected]>
* Auto-format all Python files

Signed-off-by: Curtis Maddalozzo <[email protected]>

* Use black for linting

Signed-off-by: Curtis Maddalozzo <[email protected]>

* Don't run poetry check on root pyproject.toml

Signed-off-by: Curtis Maddalozzo <[email protected]>

* Re-add flake8 linting

Signed-off-by: Curtis Maddalozzo <[email protected]>

* Fix linting errors

Signed-off-by: Curtis Maddalozzo <[email protected]>

* Add python path

Signed-off-by: Curtis Maddalozzo <[email protected]>

* Fix linting

Signed-off-by: Curtis Maddalozzo <[email protected]>

* Fix circular dependency

Signed-off-by: Curtis Maddalozzo <[email protected]>

* Fix circular dependency

Signed-off-by: Curtis Maddalozzo <[email protected]>

---------

Signed-off-by: Curtis Maddalozzo <[email protected]>
…serve#3558)

* support model revision and tokenizer revision

Signed-off-by: Lize Cai <[email protected]>

* point to specified commit in test case

Signed-off-by: Lize Cai <[email protected]>

* format code

Signed-off-by: Lize Cai <[email protected]>

---------

Signed-off-by: Lize Cai <[email protected]>
Signed-off-by: Dan Sun <[email protected]>
Co-authored-by: Dan Sun <[email protected]>
* OpenAI data models and endpoints from vLLM

Signed-off-by: Tessa Pham <[email protected]>

* more components for OpenAI endpoints

Signed-off-by: Tessa Pham <[email protected]>

* add OpenAI endpoints to router

Signed-off-by: Tessa Pham <[email protected]>

* modify generate() in data plane

Signed-off-by: Tessa Pham <[email protected]>

* class OpenAIModel

Signed-off-by: Tessa Pham <[email protected]>

* delete and rename files

Signed-off-by: Tessa Pham <[email protected]>

* add create_chat_completion() to OpenAIModel

Signed-off-by: Tessa Pham <[email protected]>

* update routers and lint

Signed-off-by: Tessa Pham <[email protected]>

* Implement streaming

Signed-off-by: Curtis Maddalozzo <[email protected]>

* Add tests for OpenAI data conversion

Signed-off-by: Curtis Maddalozzo <[email protected]>

* Register OpenAI endpoints when appropriate

Signed-off-by: Curtis Maddalozzo <[email protected]>

* Add comments

Signed-off-by: Curtis Maddalozzo <[email protected]>

* Add tests for create_completion and create_chat_completion

Signed-off-by: Curtis Maddalozzo <[email protected]>

* Remove completion types from dataplane methods

Signed-off-by: Curtis Maddalozzo <[email protected]>

* WIP

Signed-off-by: Curtis Maddalozzo <[email protected]>

* fix lint errors

Signed-off-by: Tessa Pham <[email protected]>

* update poetry.lock

Signed-off-by: Tessa Pham <[email protected]>

* update poetry.lock files

Signed-off-by: Tessa Pham <[email protected]>

* add dependency

Signed-off-by: Tessa Pham <[email protected]>

* fix test

Signed-off-by: Tessa Pham <[email protected]>

* revert poetry.lock files

Signed-off-by: Tessa Pham <[email protected]>

* add .itermconfig to .gitignore

Signed-off-by: Tessa Pham <[email protected]>

* add docker-compose.yml to .gitignore

Signed-off-by: Tessa Pham <[email protected]>

* fix build error

Signed-off-by: Tessa Pham <[email protected]>

* fix function descriptions

Signed-off-by: Tessa Pham <[email protected]>

* increase limit for model decompression size

Signed-off-by: Tessa Pham <[email protected]>

* add license & autoformat

Signed-off-by: Tessa Pham <[email protected]>

* make openai dependency mandatory

Signed-off-by: Tessa Pham <[email protected]>

* openai dependency back to optional

Signed-off-by: Tessa Pham <[email protected]>

* fix openai module import error

Signed-off-by: Tessa Pham <[email protected]>

* fix JSON unmarshalling of headers

Signed-off-by: Tessa Pham <[email protected]>

* drop formatting changes in unrelated files

Signed-off-by: Tessa Pham <[email protected]>

* fix openai_is_available()

Signed-off-by: Tessa Pham <[email protected]>

* black reformat

Signed-off-by: Tessa Pham <[email protected]>

---------

Signed-off-by: Tessa Pham <[email protected]>
Signed-off-by: Curtis Maddalozzo <[email protected]>
Co-authored-by: Curtis Maddalozzo <[email protected]>
* Fix python linter

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>

* Format e2e tests

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>

* Format hack, docs

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>

* Add py-fmt target

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>

* Update python lint workflow

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>

* Rebase master

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>

---------

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>
Copy link

openshift-ci bot commented Apr 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: spolti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Apr 8, 2024
@israel-hdez
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Apr 8, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 153e56f into opendatahub-io:master Apr 8, 2024
29 checks passed
@spolti spolti deleted the sync2 branch April 8, 2024 19:58
xieshenzh pushed a commit to xieshenzh/kserve that referenced this pull request Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.