Sync2

.github/workflows/e2e-test.yml

@@ -34,7 +34,6 @@ env:
   PADDLE_IMG: "paddleserver"
   CUSTOM_MODEL_GRPC_IMG: "custom-model-grpc"
   # Explainer images
-  ALIBI_IMG: "alibi-explainer"
   ART_IMG: "art-explainer"
   # Transformer images
   IMAGE_TRANSFORMER_IMG: "image-transformer"
@@ -218,14 +217,6 @@ jobs:
           docker image ls
           sudo ls -lh ${DOCKER_IMAGES_PATH}
 
-      - name: Upload alibi image
-        uses: actions/upload-artifact@v4
-        with:
-          name: ${{ env.EXPLAINER_ARTIFACT_PREFIX }}-${{ env.ALIBI_IMG }}-${{ github.sha }}
-          path: ${{ env.DOCKER_IMAGES_PATH }}/${{ env.ALIBI_IMG }}-${{ github.sha }}
-          compression-level: 0
-          if-no-files-found: error
-
       - name: Upload art explainer image
         uses: actions/upload-artifact@v4
         with:
@@ -337,83 +328,83 @@ jobs:
           ./test/scripts/gh-actions/status-check.sh
 
   test-transformer-explainer-mms:
-      runs-on: ubuntu-latest
-      needs:
-        [kserve-image-build, predictor-runtime-build, explainer-runtime-build]
-      steps:
-        - name: Checkout source
-          uses: actions/checkout@v4
-
-        - name: Free-up disk space
-          uses: ./.github/actions/free-up-disk-space
-
-        - name: Setup Go
-          uses: actions/setup-go@v5
-          with:
-            go-version: "1.21"
-        - name: Setup Python
-          uses: actions/setup-python@v5
-          with:
-            python-version: "3.9"
-
-        - name: Setup Minikube
-          uses: ./.github/actions/minikube-setup
-
-        - name: KServe dependency setup
-          uses: ./.github/actions/kserve-dep-setup
-
-        - name: Download base images
-          uses: ./.github/actions/base-download
-
-        - name: Download transformer and explainer artifacts
-          uses: actions/download-artifact@v4
-          with:
-            path: ./tmp
-            pattern: +(${{ env.TRANSFORMER_ARTIFACT_PREFIX }}|${{ env.EXPLAINER_ARTIFACT_PREFIX }})-*
-            merge-multiple: true
-
-        - name: Download sklearn server image
-          uses: actions/download-artifact@v4
-          with:
-            name: ${{ env.PREDICTOR_ARTIFACT_PREFIX }}-${{ env.SKLEARN_IMG }}-${{ github.sha }}
-            path: ./tmp
-
-        - name: Download custom model grpc image
-          uses: actions/download-artifact@v4
-          with:
-            name: ${{ env.PREDICTOR_ARTIFACT_PREFIX }}-${{ env.CUSTOM_MODEL_GRPC_IMG }}-${{ github.sha }}
-            path: ./tmp
-
-        - name: Download xgb server image
-          uses: actions/download-artifact@v4
-          with:
-            name: ${{ env.PREDICTOR_ARTIFACT_PREFIX }}-${{ env.XGB_IMG }}-${{ github.sha }}
-            path: ./tmp
-
-        - name: Load docker images
-          uses: ./.github/actions/load-docker-images
-          with:
-            directory: ./tmp
-
-        - name: Install Poetry and version plugin
-          run: ./test/scripts/gh-actions/setup-poetry.sh
-
-        - name: Install KServe
-          run: |
-            ./test/scripts/gh-actions/setup-kserve.sh
-
-            kubectl get pods -n kserve
-            kubectl describe pods -n kserve
-
-        - name: Run E2E tests
-          timeout-minutes: 30
-          run: |
-            ./test/scripts/gh-actions/run-e2e-tests.sh "transformer or mms or collocation or explainer" "6"
-
-        - name: Check system status
-          if: always()
-          run: |
-            ./test/scripts/gh-actions/status-check.sh
+    runs-on: ubuntu-latest
+    needs:
+      [kserve-image-build, predictor-runtime-build, explainer-runtime-build]
+    steps:
+      - name: Checkout source
+        uses: actions/checkout@v4
+
+      - name: Free-up disk space
+        uses: ./.github/actions/free-up-disk-space
+
+      - name: Setup Go
+        uses: actions/setup-go@v5
+        with:
+          go-version: "1.21"
+      - name: Setup Python
+        uses: actions/setup-python@v5
+        with:
+          python-version: "3.9"
+
+      - name: Setup Minikube
+        uses: ./.github/actions/minikube-setup
+
+      - name: KServe dependency setup
+        uses: ./.github/actions/kserve-dep-setup
+
+      - name: Download base images
+        uses: ./.github/actions/base-download
+
+      - name: Download transformer and explainer artifacts
+        uses: actions/download-artifact@v4
+        with:
+          path: ./tmp
+          pattern: +(${{ env.TRANSFORMER_ARTIFACT_PREFIX }}|${{ env.EXPLAINER_ARTIFACT_PREFIX }})-*
+          merge-multiple: true
+
+      - name: Download sklearn server image
+        uses: actions/download-artifact@v4
+        with:
+          name: ${{ env.PREDICTOR_ARTIFACT_PREFIX }}-${{ env.SKLEARN_IMG }}-${{ github.sha }}
+          path: ./tmp
+
+      - name: Download custom model grpc image
+        uses: actions/download-artifact@v4
+        with:
+          name: ${{ env.PREDICTOR_ARTIFACT_PREFIX }}-${{ env.CUSTOM_MODEL_GRPC_IMG }}-${{ github.sha }}
+          path: ./tmp
+
+      - name: Download xgb server image
+        uses: actions/download-artifact@v4
+        with:
+          name: ${{ env.PREDICTOR_ARTIFACT_PREFIX }}-${{ env.XGB_IMG }}-${{ github.sha }}
+          path: ./tmp
+
+      - name: Load docker images
+        uses: ./.github/actions/load-docker-images
+        with:
+          directory: ./tmp
+
+      - name: Install Poetry and version plugin
+        run: ./test/scripts/gh-actions/setup-poetry.sh
+
+      - name: Install KServe
+        run: |
+          ./test/scripts/gh-actions/setup-kserve.sh
+          
+          kubectl get pods -n kserve
+          kubectl describe pods -n kserve
+
+      - name: Run E2E tests
+        timeout-minutes: 30
+        run: |
+          ./test/scripts/gh-actions/run-e2e-tests.sh "transformer or mms or collocation or explainer" "6"
+
+      - name: Check system status
+        if: always()
+        run: |
+          ./test/scripts/gh-actions/status-check.sh
 
   test-graph:
     runs-on: ubuntu-latest
@@ -730,6 +721,12 @@ jobs:
           name: ${{ env.PREDICTOR_ARTIFACT_PREFIX }}-${{ env.SKLEARN_IMG }}-${{ github.sha }}
           path: ./tmp
 
+      - name: Download xgb server image
+        uses: actions/download-artifact@v4
+        with:
+          name: ${{ env.PREDICTOR_ARTIFACT_PREFIX }}-${{ env.XGB_IMG }}-${{ github.sha }}
+          path: ./tmp
+
       - name: Download custom model grpc image
         uses: actions/download-artifact@v4
         with:

.github/workflows/python-test.yml

@@ -12,7 +12,7 @@ concurrency:
   cancel-in-progress: true
 
 jobs:
-  flake8-lint:
+  lint:
     runs-on: ubuntu-latest
     strategy:
       matrix:
@@ -25,11 +25,18 @@ jobs:
         uses: actions/setup-python@v5
         with:
           python-version: ${{ matrix.python-version }}
-      - name: flake8 Lint
+      - name: Lint with flake8
         uses: py-actions/flake8@v2
         with:
-          max-line-length: "120"
-          exclude: "docs/samples/v1beta1/onnx/assets/*.py,python/kserve/kserve/*.py,python/kserve/test/test_v1*.py,python/kserve/kserve/__init__.py,python/kserve/test/__init__.py,python/kserve/test/test_knative*.py,python/kserve/kserve/protocol/grpc/grpc_predict_v2*.py"
+          args: "--config python/.flake8"
+          path: "."
+
+      - name: Check formatting with black
+        uses: psf/black@stable
+        with:
+          options: "--check --diff --config python/pyproject.toml"
+          src: "."
+          version: "~= 24.3"
   build:
     runs-on: ubuntu-latest
     strategy:

.github/workflows/scheduled-image-scan.yml

@@ -45,7 +45,8 @@ jobs:
 
       - name: Upload sarif file to Github Code Scanning
         if: always()
-        uses: github/codeql-action/upload-sarif@v2
+        continue-on-error: true #avoid fail the pipeline if the SARIF upload fails.
+        uses: github/codeql-action/upload-sarif@v3
         with:
           sarif_file: application/${{ matrix.image.name }}/docker.snyk.sarif
 
@@ -92,7 +93,6 @@ jobs:
       matrix:
         image:
           [
-            { name: alibi-explainer, file: python/alibiexplainer.Dockerfile },
             { name: art-explainer, file: python/artexplainer.Dockerfile },
           ]
 

.gitignore

@@ -66,3 +66,9 @@ python/kserve/tox.ini
 
 # Downloaded by hack install
 hack/istio-*
+
+# iTerm config
+.itermconfig
+
+# Docker config
+docker-compose.yml