RHOAIENG-18793: chore(components/): delete the components we don't use in ODH-io #512
Conversation
|
Don't we exclude that folders from snyk scanning with this: https://github.com/jiridanek/kubeflow/blob/jd_followup_minimal_diff/.snyk ? |
|
Synk file is only used for snyk, not for the cve reporting into jira that prodsec in Red hat does. But good point, if we delete the components, we should also purge them from the .snyk file! |
jiridanek
force-pushed
the
jd_followup_minimal_diff
branch
from
126dc70 to
b9cae19
Compare
|
Ditch of all the irrelevant components is a good thing to do. But we should be aware that this may brought in eventual complications in case we'll decided to perform regular syncs from the github.com/kubeflow/kubeflow upstream repository. In case that we will be doing these sync manually just couple of times in the year, then it's not an issue; but in case we'll be doing such more often, in such case this could be a bit annoying. |
|
Informally approved at meeting #512 and in slack https://redhat-internal.slack.com/archives/C060A5FJEAD/p1740036857191859?thread_ts=1739987024.740139&cid=C060A5FJEAD |
it would be manual for sometime, |
|
/approve |
|
@jiridanek: /override requires failed status contexts, check run or a prowjob name to operate on.
Only the following failed contexts/checkruns were expected:
If you are trying to override a checkrun that has a space in it, you must put a double quote on the context. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jiridanek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/override "golangci-lint (components/notebook-controller)" "golangci-lint (components/odh-notebook-controller)" |
|
@jiridanek: Overrode contexts on behalf of jiridanek: golangci-lint (components/notebook-controller), golangci-lint (components/odh-notebook-controller) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@harshad16 merging the renovate.json config in #514 would be a better solution, but yes, deleting the components will also help deal with autoupdates ;p |
openshift-merge-bot
bot
merged commit d109b88
into
opendatahub-io:main
|
I'm splitting off the renovate.json5 change into its own PR, for easier review |
NBC:
ONBC:
Description
kubeflow/components/access-management/go.mod
Line 26 in 672e102
It appears that we carry around lots of code in the
components/subdirectory that we don't build and ship in ODH-io. Let's delete the components we don't use.How Has This Been Tested?
It builds.
Merge criteria: