-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RHOAIENG-18401, RHOAIENG-18402: chore(.github/renovate.json5): configure Renovate for ODH-io/kubeflow repository #533
RHOAIENG-18401, RHOAIENG-18402: chore(.github/renovate.json5): configure Renovate for ODH-io/kubeflow repository #533
Conversation
20691d1
to
19b25d8
Compare
19b25d8
to
7026851
Compare
"description": [ | ||
"https://raw.githubusercontent.com/red-hat-data-services/kubeflow/refs/heads/main/.github/renovate.json", | ||
"https://konflux.pages.redhat.com/docs/users/mintmaker/user.html", | ||
"https://github.com/konflux-ci/mintmaker/blob/main/config/renovate/renovate.json" | ||
], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@harshad16 This is documentation. The red-hat-data-services/kubeflow file is something that's good to keep in mind when editing this file here. It is a very relevant reference.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is hand-written, based off https://raw.githubusercontent.com/red-hat-data-services/kubeflow/refs/heads/main/.github/renovate.json
…ure Renovate for ODH-io/kubeflow repository
7026851
to
83ef2ce
Compare
Just to make it clear, when you say:
Is this just a temporary solution, or is this a permanent thing and we want to fully control these updates in the future ourselves as we do now even in the konflux world? |
I'm not clear on this, tbh. If we can make renovate work for us, it will be much better than the snyk workflow. My focus is getting konflux builds, Im trying to avoid having to figure out deps management at the same time. |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jiridanek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
c4aca4e
into
opendatahub-io:main
I'm splitting off the renovate.json5 change to a separate PR for easier review.
Description
Based on the defaults at https://github.com/konflux-ci/mintmaker/blob/main/config/renovate/renovate.json
We need to stop MintMaker/Renovate from trying to update all our dependency files everywhere.
How Has This Been Tested?
https://docs.renovatebot.com/config-validation/