Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHOAIENG-18401, RHOAIENG-18402: chore(.github/renovate.json5): configure Renovate for ODH-io/kubeflow repository #533

Merged
merged 1 commit into from
Feb 27, 2025

Conversation

jiridanek
Copy link
Member

@jiridanek jiridanek commented Feb 26, 2025

I'm splitting off the renovate.json5 change to a separate PR for easier review.

Description

Based on the defaults at https://github.com/konflux-ci/mintmaker/blob/main/config/renovate/renovate.json

We need to stop MintMaker/Renovate from trying to update all our dependency files everywhere.

How Has This Been Tested?

https://docs.renovatebot.com/config-validation/

$ (cd .github; npx --yes --package renovate -- renovate-config-validator)
  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Sorry, something went wrong.

Comment on lines +5 to +9
"description": [
"https://raw.githubusercontent.com/red-hat-data-services/kubeflow/refs/heads/main/.github/renovate.json",
"https://konflux.pages.redhat.com/docs/users/mintmaker/user.html",
"https://github.com/konflux-ci/mintmaker/blob/main/config/renovate/renovate.json"
],
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@harshad16 This is documentation. The red-hat-data-services/kubeflow file is something that's good to keep in mind when editing this file here. It is a very relevant reference.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

…ure Renovate for ODH-io/kubeflow repository
@jstourac
Copy link
Member

Just to make it clear, when you say:

We need to stop MintMaker/Renovate from trying to update all our dependency files everywhere.

Is this just a temporary solution, or is this a permanent thing and we want to fully control these updates in the future ourselves as we do now even in the konflux world?

@jiridanek
Copy link
Member Author

I'm not clear on this, tbh. If we can make renovate work for us, it will be much better than the snyk workflow. My focus is getting konflux builds, Im trying to avoid having to figure out deps management at the same time.

@jstourac
Copy link
Member

/lgtm

@jiridanek
Copy link
Member Author

/approve

Copy link

openshift-ci bot commented Feb 27, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jiridanek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit c4aca4e into opendatahub-io:main Feb 27, 2025
10 checks passed
@jiridanek jiridanek deleted the jd_renovate branch February 27, 2025 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants