-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RHOAIENG-20088: chore(tests/containers) + GHA CI update: check images size change #901
base: main
Are you sure you want to change the base?
Conversation
Skipping CI for Draft Pull Request. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
50c63a4
to
7319df6
Compare
7319df6
to
d6331d8
Compare
d6331d8
to
fb7599a
Compare
fb7599a
to
8201d5c
Compare
8201d5c
to
84b0b4e
Compare
Didn't expect that many CI failures with this run - looks like the image sizes differ here against what I checked it locally. I'll check what is the rootcause tomorrow. Also, I tried to raise a testing PR with the updated pipfiles to force the images being build jstourac#7 . Let's see. |
Okay, after some more checks also on the testing PR on my own fork #jstourac/pull/7, it looks like the cache we use for our builds may vary between different repository forks. This may affect the resulting size of the image for different users. After consultation with Jiri, we think that the solution might be either in disabling the cache (well, we don't like it because the builds may take quite a long time to be done - but we haven't try). Another option might be to switch from tag to sha for our base images. This is something that will be done as part of the migration to konflux. Well, for now - so that we can move on a little bit at least, I'll split this PR into two separate ones - one (this) will be kept only for the pytest based check. The other will be for the bash based checks for GHA CI checking when images are updated in params.env file (#912). This PR will be worked on a bit later. |
95b3efc
to
d39b6ba
Compare
Adds a new test to our pytest set to check the given image size compared to the expected value. In this test we are checking the uncompressed image size by summing up all the layeres of the image. This image is usually downloaded on the machine where this is being run already. https://issues.redhat.com/browse/RHOAIENG-20088
d39b6ba
to
bc5a783
Compare
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Description
Enhances our existing ci scripts for the params.env and existing
runtimes definitions with the actual image size check - we have preset
expected size for each of the image and we check that this size isn't
changed too much.
With this implementation we are checking the compressed image size to
avoid the image download.
Adds a new test to our pytest set to check the given image size compared
to the expected value. In this test we are checking the uncompressed
image size by summing up all the layeres of the image. This image is
usually downloaded on the machine where this is being run already.
https://issues.redhat.com/browse/RHOAIENG-20088
How Has This Been Tested?
Local execution of the:
and for the Pytest:
We shall check all the existing images before merging this, though.
Merge criteria: