-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RHOAIENG-20088: chore(GHA CI): check images size change #912
RHOAIENG-20088: chore(GHA CI): check images size change #912
Conversation
Enhances our existing ci scripts for the params.env and existing runtimes definitions with the actual image size check - we have preset expected size for each of the image and we check that this size isn't changed too much. With this implementation we are checking the compressed image size to avoid the image download. https://issues.redhat.com/browse/RHOAIENG-20088
/lgtm |
/override ci/prow/images |
@jiridanek: Overrode contexts on behalf of jiridanek: ci/prow/images In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great work, just one question
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
👍
Thank you guys! /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jstourac The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/override ci/prow/images |
@jstourac: Overrode contexts on behalf of jstourac: ci/prow/images In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Enhances our existing ci scripts for the params.env and existing runtimes definitions with the actual image size check - we have preset expected size for each of the image and we check that this size isn't changed too much.
With this implementation we are checking the compressed image size to avoid the image download.
https://issues.redhat.com/browse/RHOAIENG-20088
How Has This Been Tested?
Local execution of the:
Merge criteria: