Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHOAIENG-20088: chore(GHA CI): check images size change #912

Merged
merged 1 commit into from
Feb 26, 2025

Conversation

jstourac
Copy link
Member

Enhances our existing ci scripts for the params.env and existing runtimes definitions with the actual image size check - we have preset expected size for each of the image and we check that this size isn't changed too much.

With this implementation we are checking the compressed image size to avoid the image download.

https://issues.redhat.com/browse/RHOAIENG-20088

How Has This Been Tested?

Local execution of the:

./ci/check-params-env.sh
./ci/check-runtime-images.sh

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Enhances our existing ci scripts for the params.env and existing
runtimes definitions with the actual image size check - we have preset
expected size for each of the image and we check that this size isn't
changed too much.

With this implementation we are checking the compressed image size to
avoid the image download.

https://issues.redhat.com/browse/RHOAIENG-20088
@jiridanek
Copy link
Member

/lgtm

@jiridanek
Copy link
Member

/override ci/prow/images

Copy link
Contributor

openshift-ci bot commented Feb 20, 2025

@jiridanek: Overrode contexts on behalf of jiridanek: ci/prow/images

In response to this:

/override ci/prow/images

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work, just one question

Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

👍

@jstourac
Copy link
Member Author

Thank you guys!

/approve

Copy link
Contributor

openshift-ci bot commented Feb 26, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jstourac

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jstourac
Copy link
Member Author

/override ci/prow/images

Copy link
Contributor

openshift-ci bot commented Feb 26, 2025

@jstourac: Overrode contexts on behalf of jstourac: ci/prow/images

In response to this:

/override ci/prow/images

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot bot merged commit d1fe5bc into opendatahub-io:main Feb 26, 2025
8 checks passed
@jstourac jstourac deleted the testImgSizeBash branch February 26, 2025 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants