-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release demo ecologie 20250305-1 #679
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* indicators: filter by global_tag_prefix fix ecolabdata/ecospheres#530 * indicator: custom card in bouquet detail * fix imports * remove fixme * new organization id on demo
…previous accessibility problems (#669)
* Update Tags for indicators filters Last update of the filters used in the indicator view on ecologie.data.gouv.fr * Apply suggestions from code review Co-authored-by: Alexandre Bulté <[email protected]> * Update configs/ecospheres/config.yaml Co-authored-by: Alexandre Bulté <[email protected]> --------- Co-authored-by: Alexandre Bulté <[email protected]>
* fix(forms): add description for DS title * fix(a11y forms): better form accessibility add search role or tag fix type on pages with search (not always form related) * fix(a11y forms): accessibility fixes for DatasetAddToBouquetModal * fix(a11y forms): clean DatasetAddToBouquetModal * fix(a11y forms): fix types * fix(a11y forms): refactor validation create a composable for error handling create a component for error summary * fix(a11y forms): refactor validation Create error message component Handle error messages inside composable Handle form validation inside DatasetEditModal * fix(a11y forms): remove comments * fix(a11y forms): refactor onSubmit * fix(a11y forms): merge main + update vite config * fix(a11y forms): validation add validation rules for dataset availability use aria-errormessage where relevant harmonize error messages editorial tone * fix(a11y forms): dataset availability
✅ Deploy Preview for ecospheres ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for meteo-france ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
* fix: handle dataset (and indicator) with no file * fix: wording * move message to resourceslist component
* feat(dataset): multi attribution * remove custom constact point display * fix types * fix org logo in sidebar * Producteur <-> Editeur * fix condition
* feat: clone while keeping datasets (or not) * Update src/views/bouquets/BouquetDetailView.vue Co-authored-by: streino <[email protected]> --------- Co-authored-by: streino <[email protected]>
streino
approved these changes
Mar 5, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✨
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.