-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(bdd): adding bdd test cases for LVM Driver #26
Conversation
7be6d46
to
47fe7ef
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments:
- builder code can be moved from
tests/
topkg/builder
- Test to check , volume resize is not done, if a snapshot exists
7a2ecf6
to
189299d
Compare
9393dd2
to
80b3d2e
Compare
Codecov Report
@@ Coverage Diff @@
## master #26 +/- ##
======================================
Coverage 1.20% 1.20%
======================================
Files 11 11
Lines 830 830
======================================
Hits 10 10
Misses 820 820 Continue to review full report at Codecov.
|
Signed-off-by: Pawan <[email protected]>
Signed-off-by: Pawan <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Pawan [email protected]
Why is this PR required? What issue does it fix?:
adding bdd test case for LVM Driver. test cases added are