Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(action): migrating to github action from travis #27

Merged
merged 4 commits into from
Mar 4, 2021

Conversation

pawanpraka1
Copy link
Contributor

@pawanpraka1 pawanpraka1 commented Mar 3, 2021

removed the .travis file and moved all the bdd test cases to github action.

Copy link
Contributor

@akhilerm akhilerm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pawanpraka1 A few comments:

  1. Should the BDD tests be done for the build workflow also?
  2. The travis.yml file can be deleted.

@pawanpraka1
Copy link
Contributor Author

pawanpraka1 commented Mar 4, 2021

@akhilerm

Should the BDD tests be done for the build workflow also?

I thought about it did not see the benefit of doing that.

The travis.yml file can be deleted.

Have not deleted it purposely as there are now ansible images added from e2e team in the repo, it is not using multiarch build.

@akhilerm
Copy link
Contributor

akhilerm commented Mar 4, 2021

I thought about it did not see the benefit of doing that.

If all the PRs will be always rebased and merged, then its not needed. But we cannot guarantee that. Consider the case where, change X in PR-1 and change Y in PR-2. The BDD will be tested on both of them separately. Suppose PR-2 is merged and then PR-1 is merged, without rebasing, then the combined changes X and Y wont be tested in the BDD. If we include the bdd in the build workflow, we can guarantee that the changes in the master is tested.

Have not deleted it purposely as there are now ansible images added from e2e team in the repo, it is not using multiarch build.
Single platform images can also be built on github actions. Just like how we build normally in our local setup.

@pawanpraka1
Copy link
Contributor Author

If we include the bdd in the build workflow, we can guarantee that the changes in the master is tested.

will add for build also.

Single platform images can also be built on github actions. Just like how we build normally in our local setup.

We need to have DNMAE and DPASS setting in the github action, or another way could be if we change the code to use the DOCKER-HUB token and password.

@pawanpraka1
Copy link
Contributor Author

Also what about quay and the images which are built with arch name?

@akhilerm
Copy link
Contributor

akhilerm commented Mar 4, 2021

Also what about quay and the images which are built with arch name?

Images with arch suffix are not used in charts or operator files. Support for pushing to quay is available if using docker/build-push-action

@pawanpraka1 pawanpraka1 force-pushed the action branch 2 times, most recently from 85c0bea to 0d0537d Compare March 4, 2021 07:31
@pawanpraka1 pawanpraka1 requested a review from akhilerm March 4, 2021 07:54
@pawanpraka1 pawanpraka1 force-pushed the action branch 2 times, most recently from d90b398 to 947b8f7 Compare March 4, 2021 08:31
Signed-off-by: Pawan <[email protected]>
Copy link
Contributor

@akhilerm akhilerm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants