-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(action): migrating to github action from travis #27
Conversation
1e322d2
to
4fe9f0e
Compare
cc59239
to
19f6ead
Compare
Signed-off-by: Pawan <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pawanpraka1 A few comments:
- Should the BDD tests be done for the build workflow also?
- The travis.yml file can be deleted.
I thought about it did not see the benefit of doing that.
Have not deleted it purposely as there are now ansible images added from e2e team in the repo, it is not using multiarch build. |
If all the PRs will be always rebased and merged, then its not needed. But we cannot guarantee that. Consider the case where, change X in PR-1 and change Y in PR-2. The BDD will be tested on both of them separately. Suppose PR-2 is merged and then PR-1 is merged, without rebasing, then the combined changes X and Y wont be tested in the BDD. If we include the bdd in the build workflow, we can guarantee that the changes in the master is tested.
|
will add for build also.
We need to have DNMAE and DPASS setting in the github action, or another way could be if we change the code to use the DOCKER-HUB token and password. |
Also what about quay and the images which are built with arch name? |
Signed-off-by: Pawan <[email protected]>
Images with arch suffix are not used in charts or operator files. Support for pushing to quay is available if using |
85c0bea
to
0d0537d
Compare
d90b398
to
947b8f7
Compare
Signed-off-by: Pawan <[email protected]>
Signed-off-by: Pawan <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
removed the .travis file and moved all the bdd test cases to github action.