Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RVFI bugfixes #456

Merged
merged 4 commits into from
Feb 25, 2022
Merged

RVFI bugfixes #456

merged 4 commits into from
Feb 25, 2022

Conversation

halfdan-dolva
Copy link
Contributor

Fixed rvfi issue where rvfi_intr could get set due to an mret that is killed before getting to writeback.
Fixed rvfi branch handing (#452 )

Also fixed formal warning in load-store unit.

Silabs-ArjanB
Silabs-ArjanB approved these changes Feb 25, 2022
View reviewed changes
Copy link
Contributor

@Silabs-ArjanB Silabs-ArjanB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would have been cleaner to fix the pc_mux_exception related issue in the RTL instead. I will file a separate issue for that and merge this first as it is blocking progress otherwise.

@Silabs-ArjanB Silabs-ArjanB added the Component:RTL For issues in the RTL (e.g. for files in the rtl directory) label Feb 25, 2022
@Silabs-ArjanB Silabs-ArjanB merged commit 7240216 into openhwgroup:master Feb 25, 2022
@Silabs-ArjanB Silabs-ArjanB mentioned this pull request Feb 25, 2022
Closed
@halfdan-dolva halfdan-dolva deleted the rvfi_bugfix branch March 24, 2022 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Silabs-ArjanB Silabs-ArjanB Silabs-ArjanB approved these changes

Assignees
No one assigned
Labels
Component:RTL For issues in the RTL (e.g. for files in the rtl directory)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@halfdan-dolva @Silabs-ArjanB