Retrieve installer sha from installer container if present #978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we're in OpenShift CI in an installer PR, then the installer is built by rebasing on the target branch (i.e. master). The SHA that `openshift-install version` reports doesn't exist on GitHub. It's only in the environment that CI used to build the installer. This gets the PR SHA from the environment, and then fetchs the rhcos from that branch. There's a potential problem here if a PR branch is out of date. However, we really do need to get the rhcos.json from the PR branch in case it's being updated. The fixes for this are probably a bunch of API calls to see if the PR modifies rhcos.json, or actually check out the git repo which will increase the already long build time.
stbenjam
force-pushed
the
fix-ci-installer-ref
branch
from
8186198 to
60a55b8
Compare
stbenjam
changed the title
stbenjam
force-pushed
the
fix-ci-installer-ref
branch
from
cb85d33 to
7217050
Compare
|
openshift/installer#3330 is the alternative approach to save the rhcos.json |
stbenjam
force-pushed
the
fix-ci-installer-ref
branch
from
7217050 to
31c1c60
Compare
stbenjam
force-pushed
the
fix-ci-installer-ref
branch
from
31c1c60 to
dc5b175
Compare
|
Build ABORTED, see build http://10.8.144.11:8080/job/dev-tools/1662/ |
stbenjam
changed the title
|
current CI run is past these changes -- http://10.8.144.11:8080/job/dev-tools/1663/console |
|
Build FAILURE, see build http://10.8.144.11:8080/job/dev-tools/1663/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we're in OpenShift CI in an installer PR, then the installer is
built by rebasing on the target branch (i.e. master). The SHA that
openshift-install versionreports doesn't exist on GitHub. It's onlyin the environment that CI used to build the installer.
This gets the rhcos.json that's now in the baremetal-installer container. This avoids the CI problem, and avoids making any GitHub URL calls in 4.5 or later.