Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vagrant and CI tests for Ubuntu 22.04 #2691

Merged
merged 2 commits into from
Jul 11, 2022
Merged

Conversation

mtmail
Copy link
Collaborator

@mtmail mtmail commented May 2, 2022

Ubuntu 22 LTS got released https://wiki.ubuntu.com/Releases

The ci-tests.yml still have some mentions of CentOS, I wasn't sure if we want to remove them as well.

@lonvia
Copy link
Member

lonvia commented May 3, 2022

You need to make the script executable.

The ci-tests.yml still have some mentions of CentOS, I wasn't sure if we want to remove them as well.

Just leave them, I haven't made up my mind about #2601 yet.

@mtmail
Copy link
Collaborator Author

mtmail commented May 3, 2022

Somewhere while running Purging configuration files for postgresql-common (238.pgdg20.04+1) ... for Ubuntu 22 there is a dependency failure related to R. https://cloud.r-project.org/bin/linux/ubuntu/fullREADME.html doesn't have Ubuntu 22 packages released yet. I'd say we wait a bit longer instead of trying to add work-arounds.

@lonvia
Copy link
Member

lonvia commented May 3, 2022

Oh, did this include the tests already? I don't think it's worth bothering before there is an official Ubuntu 22 Github Actions environment. But I see that the installation run works fine. So lets keep that.

@mtmail
Copy link
Collaborator Author

mtmail commented May 6, 2022

Github Actions has Ubuntu 22 in pubic beta now actions/runner-images#5490

@lonvia
Copy link
Member

lonvia commented May 10, 2022

Oh lovely, phpunit has breaking changes, too.

Repeating my recommendation from above: let's get the installation instruction + CI Tests / install merged. Then tackle all the failing tests and checks one after another in separate PRs.

@mtmail
Copy link
Collaborator Author

mtmail commented May 10, 2022

#2706 deals with the phpunit failures. Tested locally on Ubuntu 20 and 22.

@lonvia lonvia merged commit 33cb925 into osm-search:master Jul 11, 2022
@lonvia
Copy link
Member

lonvia commented Jul 11, 2022

Jay!

@mtmail mtmail deleted the ubuntu-22 branch April 23, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants