Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: transfer cl position to new owner #6623
feat: transfer cl position to new owner #6623
Changes from 17 commits
efc7fba
3c0dbd4
bca1533
dff2315
231ada1
5cfe3bf
198cf74
21195ee
39bac77
07be722
4346b86
2528e96
0dc9123
febb5d4
16e9829
920b1a4
1b04c86
5d6f510
bb936a1
9cd487e
3ab50f1
56eea8d
0254345
57fe3ca
b17bd2c
c96b505
c9ecd14
bb9706c
2ac0230
ad2b3c3
fd24b80
e68d661
04a3a68
710bd89
a6d8092
0b8367a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to sort the result before returning because map iterations are non-deterministic.
Please also make sure that unsorting is caught by tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah good call, sorted the results and added both sorted and unsorted tests 3ab50f1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also add tests:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tests extended here 56eea8d